chrome/renderer/resources/extensions/automation/automation_node.js - Issue 880063002: Ensure WebView notifies desktop automation on creation, destruction, and change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/automation/automation_node.js

Issue 880063002: Ensure WebView notifies desktop automation on creation, destruction, and change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix leaks? Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js ('k') | chrome/test/base/extension_js_browser_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/automation/automation_node.js

diff --git a/chrome/renderer/resources/extensions/automation/automation_node.js b/chrome/renderer/resources/extensions/automation/automation_node.js

index 9dcf62619a5586e0e62426f8486d4cbbe1a8bd1b..309edacb36576db26dd0d674fd80e95144dbce5e 100644

--- a/chrome/renderer/resources/extensions/automation/automation_node.js

+++ b/chrome/renderer/resources/extensions/automation/automation_node.js

@@ -728,7 +728,7 @@ AutomationRootNodeImpl.prototype = {

// TODO(dtseng): Make into set listing all hosting node roles.

if (nodeData.role == schema.RoleType.webView) {

- if (nodeImpl.pendingChildFrame === undefined)

+ if (nodeImpl.childTreeID !== nodeData.intAttributes.childTreeId)

nodeImpl.pendingChildFrame = true;

if (nodeImpl.pendingChildFrame) {

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js ('k') | chrome/test/base/extension_js_browser_test.h » ('j') | no next file with comments »