chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js - Issue 880063002: Ensure WebView notifies desktop automation on creation, destruction, and change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js

Issue 880063002: Ensure WebView notifies desktop automation on creation, destruction, and change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix leaks? Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js

diff --git a/chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js b/chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js

index e432a998de5f9d711f04ff24f136c4ef8509eeee..038155fe3dff1d8360f4b18982d0b3adaa94ee40 100644

--- a/chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js

+++ b/chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js

@@ -32,7 +32,14 @@ ChromeVoxNextE2ETest.prototype = {

runWithAutomation: function(doc, callback) {

this.runWithDocument(doc, function() {

chrome.automation.getTree(function(root) {

- callback(root);

+ if (root.children.length == 0) {

+ root.addEventListener('loadComplete',

+ function() {

+ callback(root);

+ }.bind(this), true);

+ } else {

+ callback(root);

+ }

}.bind(this));

}