Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 880043004: Fix stack exhaustion in CPDF_DataAvail::HaveResourceAncestor() (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix stack exhaustion in CPDF_DataAvail::HaveResourceAncestor() BUG=https://code.google.com/p/pdfium/issues/detail?id=113 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0c01ad05afe4dbc36c6aa32a10a0f98eb677d4be

Patch Set 1 #

Patch Set 2 : Actually execute test case. #

Patch Set 3 : Blank line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -4 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 4 chunks +12 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
A testing/resources/bug_113.in View 1 chunk +29 lines, -0 lines 0 comments Download
A testing/resources/bug_113.pdf View 1 2 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Tom Sepez
And one more place where we hit the stack exhaustion issue.
5 years, 10 months ago (2015-02-02 22:50:28 UTC) #2
Tom Sepez
Lei, please review. I expect this to remain a common issue because we don't want ...
5 years, 10 months ago (2015-02-02 23:03:05 UTC) #3
Tom Sepez
(Resisting the tempation to convert tail recursion to iteration).
5 years, 10 months ago (2015-02-02 23:04:57 UTC) #4
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-04 00:02:37 UTC) #5
Lei Zhang
On 2015/02/04 00:02:37, Lei Zhang wrote: > lgtm Actually, do you need to add a ...
5 years, 10 months ago (2015-02-04 00:03:06 UTC) #6
Tom Sepez
> Actually, do you need to add a test to load bug_113.pdf? Uh, yes. Nice ...
5 years, 10 months ago (2015-02-04 00:08:47 UTC) #7
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-04 00:17:21 UTC) #9
Tom Sepez
5 years, 10 months ago (2015-02-04 00:18:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
0c01ad05afe4dbc36c6aa32a10a0f98eb677d4be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698