Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 880023002: Fix variable shadowing in TLS code on VS2015 (Closed)

Created:
5 years, 11 months ago by scottmg
Modified:
5 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2015-histogram-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix variable shadowing in TLS code on VS2015 d:\src\cr3\src\base\threading\thread_local_storage.cc(143): error C2220: warning treated as error - no 'object' file generated d:\src\cr3\src\base\threading\thread_local_storage.cc(143): warning C4457: declaration of 'value' hides function parameter d:\src\cr3\src\base\threading\thread_local_storage.cc(110): note: see declaration of 'value' R=thakis@chromium.org BUG=440500 Committed: https://crrev.com/6c2204658de1f7ed8350c43d522c592272aaa821 Cr-Commit-Position: refs/heads/master@{#313342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M base/threading/thread_local_storage.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
5 years, 11 months ago (2015-01-27 19:12:46 UTC) #2
Nico
lgtm
5 years, 11 months ago (2015-01-27 19:21:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880023002/1
5 years, 11 months ago (2015-01-27 19:26:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 20:21:07 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 20:23:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c2204658de1f7ed8350c43d522c592272aaa821
Cr-Commit-Position: refs/heads/master@{#313342}

Powered by Google App Engine
This is Rietveld 408576698