spinning-square.sky doesn't spin

spinning-square.sky doesn't spin

The semantics of requestAnimationFrame and scheduleVisualUpdate are slightly
different. If you're inside a requestAnimationFrame, then calling
requestAnimationFrame should schedule you for next frame. However, if you're
inside a requestAnimationFrame and you scheduleVisualUpdate, that's a noop
because we've already got a visual update pending. When we merge the codepaths,
we broke requestAnimationFrame because it became a noop when called inside a
request animation frame.

We really ought to split up the two roles of requestAnimationFrame (run before
the frame boundary and run once per frame).

R=esprehn@chromium.org, eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/fca750382c8f1ef001eaeea39eaa461392b599a1

[esprehn, 2015-01-27 18:57:58]

Arg yeah, PageAnimator's method and the Page's method do different things. I'll
need to think of better names.

lgtm

[esprehn, 2015-01-27 18:58:32]

On 2015/01/27 at 18:57:58, esprehn wrote:
> Arg yeah, PageAnimator's method and the Page's method do different things.
I'll need to think of better names.
> 
> lgtm

btw I might have busted animations or some other things too that were trying to
schedule more frames. Hmm, maybe we need to revert that patch.

[abarth-chromium, 2015-01-27 18:59:56]

On 2015/01/27 at 18:58:32, esprehn wrote:
> btw I might have busted animations or some other things too that were trying
to schedule more frames. Hmm, maybe we need to revert that patch.

Yeah, I'm fixing animations now.

[abarth-chromium, 2015-01-27 19:01:33]

Committed patchset #2 (id:20001) manually as
fca750382c8f1ef001eaeea39eaa461392b599a1 (presubmit successful).