Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2289)

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 8800006: Support chrome-extension:// scheme in URLPattern. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed merge issues in unit tests Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_webrequest_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_tabs_module.cc
diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc
index 71d3b83233ddd2b9e28e3c0de505a5170dbc1290..5f33e3a113317cc1bbe087266bcb6931ce54522a 100644
--- a/chrome/browser/extensions/extension_tabs_module.cc
+++ b/chrome/browser/extensions/extension_tabs_module.cc
@@ -727,6 +727,9 @@ bool QueryTabsFunction::RunImpl() {
loading = (status == keys::kStatusValueLoading) ? MATCH_TRUE : MATCH_FALSE;
}
+ // It is o.k. to use URLPattern::SCHEME_ALL here because this function does
+ // not grant access to the content of the tabs, only to seeing their URLs and
+ // meta data.
URLPattern url_pattern(URLPattern::SCHEME_ALL, "<all_urls>");
if (query->HasKey(keys::kUrlKey)) {
std::string value;
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_webrequest_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698