chrome/browser/component_updater/pnacl/pnacl_component_installer.cc - Issue 879993005: Add support for uninstalling components and use it in SupervisedUserWhitelistInstaller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/pnacl/pnacl_component_installer.cc

Issue 879993005: Add support for uninstalling components and use it in SupervisedUserWhitelistInstaller. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: fix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/pnacl/pnacl_component_installer.h ('k') | chrome/browser/component_updater/recovery_component_installer.cc » ('j') | components/component_updater/component_updater_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/pnacl/pnacl_component_installer.cc

diff --git a/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc b/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc

index 785df6a93a1fdbbf6ae2b67f493ee5d6deaa1806..9a0c708cc31907a9e655f062a770fd17f29e1ed1 100644

--- a/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc

+++ b/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc

@@ -280,6 +280,10 @@ bool PnaclComponentInstaller::GetInstalledFile(const std::string& file,

return true;

}

+bool PnaclComponentInstaller::Uninstall() {

+ return false;

CrxComponent PnaclComponentInstaller::GetCrxComponent() {

CrxComponent pnacl_component;

pnacl_component.version = current_version();