Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 879993004: Remove ScrollableArea and Scrollbar (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1393 lines) Patch
M sky/engine/core/css/CSSPrimitiveValueMappings.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Element.cpp View 2 chunks +8 lines, -67 lines 0 comments Download
M sky/engine/core/editing/EditorCommand.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M sky/engine/core/frame/FrameView.h View 3 chunks +2 lines, -8 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 3 chunks +0 lines, -20 lines 0 comments Download
M sky/engine/core/frame/Settings.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/Settings.in View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/EventHandler.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 3 chunks +1 line, -15 lines 0 comments Download
M sky/engine/core/page/Page.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/HitTestResult.h View 4 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/HitTestResult.cpp View 5 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 4 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 3 chunks +1 line, -15 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerModelObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderView.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/Widget.h View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/platform/scroll/ScrollAnimator.h View 1 chunk +0 lines, -102 lines 0 comments Download
D sky/engine/platform/scroll/ScrollAnimator.cpp View 1 chunk +0 lines, -100 lines 0 comments Download
M sky/engine/platform/scroll/ScrollTypes.h View 1 chunk +11 lines, -0 lines 0 comments Download
D sky/engine/platform/scroll/ScrollableArea.h View 1 chunk +0 lines, -189 lines 0 comments Download
D sky/engine/platform/scroll/ScrollableArea.cpp View 1 chunk +0 lines, -258 lines 0 comments Download
D sky/engine/platform/scroll/Scrollbar.h View 1 chunk +0 lines, -149 lines 0 comments Download
D sky/engine/platform/scroll/Scrollbar.cpp View 1 chunk +0 lines, -384 lines 0 comments Download
M sky/engine/public/platform/WebFallbackThemeEngine.h View 3 chunks +0 lines, -21 lines 0 comments Download
M sky/engine/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 11 months ago (2015-01-27 19:30:52 UTC) #1
eseidel
lgtm
5 years, 11 months ago (2015-01-27 20:07:53 UTC) #2
abarth-chromium
5 years, 11 months ago (2015-01-27 20:08:28 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
587b294666471f5f2c37ecbb6d1ae7e041447096 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698