Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 879993003: Fix serialization of background property with multiple layers (Closed)

Created:
5 years, 11 months ago by rwlbuis
Modified:
5 years, 10 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix serialization of background property with multiple layers When there are multiple background layers involved the serialization has to be done per layer with the final layer last. So change valuesForBackgroundShorthand to implement this. BUG=450662 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189118

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -17 lines) Patch
A LayoutTests/fast/backgrounds/background-shorthand-multiple-layers.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/fast/backgrounds/background-shorthand-multiple-layers-expected.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/css/RenderStyleCSSValueMapping.cpp View 1 chunk +23 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
5 years, 11 months ago (2015-01-27 22:10:40 UTC) #2
Timothy Loh
lgtm
5 years, 11 months ago (2015-01-28 05:28:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879993003/20001
5 years, 10 months ago (2015-01-28 15:20:20 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 16:41:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189118

Powered by Google App Engine
This is Rietveld 408576698