Issue 879993003: Fix serialization of background property with multiple layers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 879993003: Fix serialization of background property with multiple layers (Closed)

Created:
5 years, 11 months ago by rwlbuis

Modified:
5 years, 10 months ago

Reviewers:
Timothy Loh

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix serialization of background property with multiple layers When there are multiple background layers involved the serialization has to be done per layer with the final layer last. So change valuesForBackgroundShorthand to implement this. BUG=450662 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189118

Patch Set 1 #

Patch Set 2 : Add test #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -17 lines)			Patch
A	LayoutTests/fast/backgrounds/background-shorthand-multiple-layers.html	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/backgrounds/background-shorthand-multiple-layers-expected.txt	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/core/css/RenderStyleCSSValueMapping.cpp	View		1 chunk	+23 lines, -17 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879993003/20001

5 years, 10 months ago (2015-01-28 15:20:20 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-01-28 16:41:53 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189118

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages