Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3921)

Unified Diff: base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java

Issue 879993002: [Android] Add support for command-line flags via annotation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix gtests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java
diff --git a/base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java b/base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java
new file mode 100644
index 0000000000000000000000000000000000000000..b4dccd2d48e956be06f8e6f5e69e5ab8efb3099a
--- /dev/null
+++ b/base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java
@@ -0,0 +1,43 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.base.test.util;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Inherited;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/**
+ * Provides annotations related to command-line flag handling.
+ *
+ * Note that this class should never be instantiated.
+ */
+public class CommandLineFlags {
nyquist 2015/01/28 23:10:36 Nit: Since this class should never be instantiated
Ted C 2015/01/29 00:39:51 I'm worried that this file name will cause confusi
jbudorick 2015/01/29 04:46:45 Done.
+
+ /**
+ * Adds command-line flags to the CommandLine for this test.
nyquist 2015/01/28 23:10:36 Nit: Either use {@link org.chromium.base.CommandLi
jbudorick 2015/01/29 04:46:45 @link added.
+ */
+ @Inherited
+ @Retention(RetentionPolicy.RUNTIME)
+ @Target({ElementType.METHOD, ElementType.TYPE})
+ public static @interface Add {
nyquist 2015/01/28 23:10:36 Nit: |static| is redundant for inner interfaces he
jbudorick 2015/01/29 04:46:45 removed
+ public String[] value();
nyquist 2015/01/28 23:10:36 Nit: |public| is redundant for interface methods h
jbudorick 2015/01/29 04:46:45 removed
+ }
+
+ /**
+ * Removes command-line flags from the CommandLine from this test.
+ *
+ * Note that this can only remove flags added via @Add above.
nyquist 2015/01/28 23:10:36 Nit: {@link Add}
jbudorick 2015/01/29 04:46:45 Done.
+ */
+ @Inherited
+ @Retention(RetentionPolicy.RUNTIME)
+ @Target({ElementType.METHOD, ElementType.TYPE})
+ public static @interface Remove {
+ public String[] value();
+ }
+
+ private CommandLineFlags() {}
+}

Powered by Google App Engine
This is Rietveld 408576698