Chromium Code Reviews| Index: build/android/test_runner.py |
| diff --git a/build/android/test_runner.py b/build/android/test_runner.py |
| index 6eb368af41e282a8ec1f87a174afd94ff203356c..cbd9308623f3ac95ee4416fe20666d36aca2bba4 100755 |
| --- a/build/android/test_runner.py |
| +++ b/build/android/test_runner.py |
| @@ -127,10 +127,8 @@ def AddRemoteDeviceOptions(parser): |
| group.add_argument('--collect', default='', |
| help=('Only collects the test results if set. ' |
|
jbudorick
2015/01/28 16:09:54
w.r.t. help formatting: like this
rnephew (Wrong account)
2015/01/28 16:47:53
Acknowledged.
|
| 'Gets test_run_id from given file path.')) |
| - group.add_argument('--remote-device', default='', |
| + group.add_argument('--remote-device', action='append', |
| help='Device type to run test on.') |
| - group.add_argument('--remote-device-os', default='', |
| - help='OS to have on the device.') |
| group.add_argument('--results-path', default='', |
| help='File path to download results to.') |
| group.add_argument('--api-protocol', |
| @@ -143,6 +141,15 @@ def AddRemoteDeviceOptions(parser): |
| group.add_argument('--device-type', default='Android', |
| choices=constants.VALID_DEVICE_TYPES, |
| help=('Type of device to run on. iOS or android')) |
| + group.add_argument('--device-oem', help='Device OEM to run on.') |
| + group.add_argument('--remote-device-file', help=('File with JSON to select' |
|
jbudorick
2015/01/28 16:09:54
nit: put help on its own line and indent subsequen
rnephew (Wrong account)
2015/01/28 16:47:53
Done.
|
| + ' remote device. Overrides all other flags.')) |
| + |
| + device_os_group = group.add_mutually_exclusive_group() |
|
jbudorick
2015/01/28 16:09:54
I still need to look at nested mutex groups.
rnephew (Wrong account)
2015/01/28 16:47:53
Looking around, everything I found says you cant d
jbudorick
2015/01/28 23:19:09
Yeah, it doesn't look like it works the way I'd li
rnephew (Wrong account)
2015/01/29 01:58:35
Acknowledged.
|
| + device_os_group.add_argument('--remote-device-minimum-os', |
| + help='Minimum OS on device.') |
| + device_os_group.add_argument('--remote-device-os', action='append', |
| + help='OS to have on the device.') |
| api_secret_group = group.add_mutually_exclusive_group() |
| api_secret_group.add_argument('--api-secret', default='', |