build/android/pylib/remote/device/example.config - Issue 879983002: Add multiple device/os filtering and a config file.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/remote/device/example.config

Issue 879983002: Add multiple device/os filtering and a config file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 {
	jbudorick 2015/01/27 17:58:55 - Why is this a separate file? - Why isn't this ju - Why is this a separate file? - Why isn't this just a JSON? rnephew (Wrong account) 2015/01/27 18:46:21 I could add it as a comment somewhere. I just want Show quoted text On 2015/01/27 17:58:55, jbudorick wrote: > - Why is this a separate file? > - Why isn't this just a JSON? I could add it as a comment somewhere. I just wanted to give an example config file. It is. jbudorick 2015/01/27 20:01:50 Yeah, I think this should be a comment somewhere. Show quoted text On 2015/01/27 18:46:21, rnephew wrote: > On 2015/01/27 17:58:55, jbudorick wrote: > > - Why is this a separate file? > > - Why isn't this just a JSON? > > I could add it as a comment somewhere. I just wanted to give an example config > file. > > It is. Yeah, I think this should be a comment somewhere. rnephew (Wrong account) 2015/01/27 21:07:22 Added comment to remote_device_environment. Show quoted text On 2015/01/27 20:01:50, jbudorick wrote: > On 2015/01/27 18:46:21, rnephew wrote: > > On 2015/01/27 17:58:55, jbudorick wrote: > > > - Why is this a separate file? > > > - Why isn't this just a JSON? > > > > I could add it as a comment somewhere. I just wanted to give an example config > > file. > > > > It is. > > Yeah, I think this should be a comment somewhere. Added comment to remote_device_environment.
	2 "remote_device": "Galaxy S4, Galaxy S3",

	3 "remote_device_os": "4.4.2, 4.4.4",

	4 "remote_device_minimum_os": "4.4.2"

	5 "api_address": www.example.com

	6 "api_port": "80",

	7 "api_protocol": "http",

	8 "api_secret": "apisecret",

	9 "api_key": "apikey",

	10 "timeouts": {

	11 "queueing": 600,

	12 "installing": 600,

	13 "in-progress": 1800,

	14 "unknown": 300

	15 }

	16 }

OLD	NEW