Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 879953002: Explicitly call OnModelChanged when there are no titles to load (Closed)

Created:
5 years, 11 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly call OnModelChanged when there are no titles to load Fixs several release blocking regressions in the behaviour of the startup page list. Lamentably there are no tests for this code and adding new ones looks tricky (we'd either need to fix crbug.com/419370) or refactor the classes to be testable. BUG=452370, 452407 Committed: https://crrev.com/ac59daacf5d6dfd47ea67bc6ddd930b499215698 Cr-Commit-Position: refs/heads/master@{#313487}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/custom_home_pages_table_model.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
alex clarke (OOO till 29th)
5 years, 11 months ago (2015-01-27 15:28:46 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-28 11:00:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879953002/1
5 years, 11 months ago (2015-01-28 11:03:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 12:07:53 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 12:08:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac59daacf5d6dfd47ea67bc6ddd930b499215698
Cr-Commit-Position: refs/heads/master@{#313487}

Powered by Google App Engine
This is Rietveld 408576698