Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 879943003: Instrumenting NetworkChangeNotifierWin::GetCurrentConnectionType for jank (Closed)

Created:
5 years, 11 months ago by vadimt
Modified:
5 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrumenting NetworkChangeNotifierWin::GetCurrentConnectionType for jank We suspect that this method may be causing jankiness of QuicClientSession constructor BUG=422516 Committed: https://crrev.com/7810214e0a59d622add492497b61f5fa70b69d78 Cr-Commit-Position: refs/heads/master@{#313427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M net/base/network_change_notifier_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vadimt
rtenneti@, please review
5 years, 11 months ago (2015-01-27 20:51:04 UTC) #2
ramant (doing other things)
lgtm
5 years, 11 months ago (2015-01-28 01:07:49 UTC) #3
ramant (doing other things)
Sorry for the delay. Was sick and had gone home.
5 years, 11 months ago (2015-01-28 01:08:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879943003/1
5 years, 11 months ago (2015-01-28 01:09:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-28 04:09:08 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-28 04:11:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7810214e0a59d622add492497b61f5fa70b69d78
Cr-Commit-Position: refs/heads/master@{#313427}

Powered by Google App Engine
This is Rietveld 408576698