Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 879913005: Files.app: Fix date string generation for cloud import destinations. (Closed)

Created:
5 years, 10 months ago by Ben Kwa
Modified:
5 years, 10 months ago
Reviewers:
Steve McKay
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Fix date string generation for cloud import destinations. BUG=451934 Committed: https://crrev.com/9cc22248b9b04cb4baa62822808a1fd77c8a7b3f Cr-Commit-Position: refs/heads/master@{#313666}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/file_manager/file_manager/background/js/media_import_handler.js View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 13 (4 generated)
Ben Kwa
5 years, 10 months ago (2015-01-28 16:17:24 UTC) #2
Steve McKay
https://codereview.chromium.org/879913005/diff/1/ui/file_manager/file_manager/background/js/media_import_handler.js File ui/file_manager/file_manager/background/js/media_import_handler.js (right): https://codereview.chromium.org/879913005/diff/1/ui/file_manager/file_manager/background/js/media_import_handler.js#newcode500 ui/file_manager/file_manager/background/js/media_import_handler.js:500: var month = padAndConvert(date.getMonth() + 1); I think we'll ...
5 years, 10 months ago (2015-01-28 16:39:27 UTC) #3
Ben Kwa
https://codereview.chromium.org/879913005/diff/1/ui/file_manager/file_manager/background/js/media_import_handler.js File ui/file_manager/file_manager/background/js/media_import_handler.js (right): https://codereview.chromium.org/879913005/diff/1/ui/file_manager/file_manager/background/js/media_import_handler.js#newcode500 ui/file_manager/file_manager/background/js/media_import_handler.js:500: var month = padAndConvert(date.getMonth() + 1); On 2015/01/28 16:39:26, ...
5 years, 10 months ago (2015-01-28 20:58:59 UTC) #4
Steve McKay
lgtm
5 years, 10 months ago (2015-01-28 21:00:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879913005/1
5 years, 10 months ago (2015-01-28 21:02:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/29733)
5 years, 10 months ago (2015-01-28 22:40:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879913005/1
5 years, 10 months ago (2015-01-29 05:02:16 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 05:03:29 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 05:04:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cc22248b9b04cb4baa62822808a1fd77c8a7b3f
Cr-Commit-Position: refs/heads/master@{#313666}

Powered by Google App Engine
This is Rietveld 408576698