Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2018)

Unified Diff: Source/web/WebPagePopupImpl.cpp

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added FIXME comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/PopupContainerTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebPagePopupImpl.cpp
diff --git a/Source/web/WebPagePopupImpl.cpp b/Source/web/WebPagePopupImpl.cpp
index 2f90bf27b29fab0ee900f804f156d02c95a0f47f..9909058018d3d260c3c93a2571702f591f790475 100644
--- a/Source/web/WebPagePopupImpl.cpp
+++ b/Source/web/WebPagePopupImpl.cpp
@@ -80,14 +80,14 @@ private:
m_popup->closePopup();
}
- virtual FloatRect windowRect() override
+ virtual IntRect windowRect() override
{
- return FloatRect(m_popup->m_windowRectInScreen.x, m_popup->m_windowRectInScreen.y, m_popup->m_windowRectInScreen.width, m_popup->m_windowRectInScreen.height);
+ return IntRect(m_popup->m_windowRectInScreen.x, m_popup->m_windowRectInScreen.y, m_popup->m_windowRectInScreen.width, m_popup->m_windowRectInScreen.height);
}
- virtual void setWindowRect(const FloatRect& rect) override
+ virtual void setWindowRect(const IntRect& rect) override
{
- m_popup->m_windowRectInScreen = IntRect(rect);
+ m_popup->m_windowRectInScreen = rect;
m_popup->widgetClient()->setWindowRect(m_popup->m_windowRectInScreen);
}
@@ -136,9 +136,9 @@ private:
return m_popup->m_webView;
}
- virtual FloatSize minimumWindowSize() const override
+ virtual IntSize minimumWindowSize() const override
{
- return FloatSize(0, 0);
+ return IntSize(0, 0);
}
virtual void setCursor(const Cursor& cursor) override
« no previous file with comments | « Source/web/PopupContainerTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698