Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1588)

Unified Diff: Source/core/page/WindowFeatures.h

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added FIXME comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/DragController.cpp ('k') | Source/core/page/WindowFeatures.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/WindowFeatures.h
diff --git a/Source/core/page/WindowFeatures.h b/Source/core/page/WindowFeatures.h
index 086026f91c469932333c0dd690840fb627b2b55c..c1018f09a8c4c83d1d3978adf9bdaa5ce7eb548a 100644
--- a/Source/core/page/WindowFeatures.h
+++ b/Source/core/page/WindowFeatures.h
@@ -34,17 +34,17 @@
namespace blink {
-class FloatRect;
+class IntRect;
struct WindowFeatures {
WindowFeatures()
- : x(0.0f)
+ : x(0)
, xSet(false)
- , y(0.0f)
+ , y(0)
, ySet(false)
- , width(0.0f)
+ , width(0)
, widthSet(false)
- , height(0.0f)
+ , height(0)
, heightSet(false)
, menuBarVisible(true)
, statusBarVisible(true)
@@ -57,15 +57,15 @@ struct WindowFeatures {
{
}
explicit WindowFeatures(const String& windowFeaturesString);
- WindowFeatures(const String& dialogFeaturesString, const FloatRect& screenAvailableRect);
+ WindowFeatures(const String& dialogFeaturesString, const IntRect& screenAvailableRect);
- float x;
+ int x;
bool xSet;
- float y;
+ int y;
bool ySet;
- float width;
+ int width;
bool widthSet;
- float height;
+ int height;
bool heightSet;
bool menuBarVisible;
@@ -84,7 +84,7 @@ private:
using DialogFeaturesMap = HashMap<String, String>;
static void parseDialogFeatures(const String&, HashMap<String, String>&);
static bool boolFeature(const DialogFeaturesMap&, const char* key, bool defaultValue = false);
- static float floatFeature(const DialogFeaturesMap&, const char* key, float min, float max, float defaultValue);
+ static int intFeature(const DialogFeaturesMap&, const char* key, int min, int max, int defaultValue);
void setWindowFeature(const String& keyString, const String& valueString);
};
« no previous file with comments | « Source/core/page/DragController.cpp ('k') | Source/core/page/WindowFeatures.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698