Source/modules/screen_orientation/ScreenOrientationController.cpp - Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/screen_orientation/ScreenOrientationController.cpp

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/screen_orientation/ScreenOrientationController.cpp

diff --git a/Source/modules/screen_orientation/ScreenOrientationController.cpp b/Source/modules/screen_orientation/ScreenOrientationController.cpp

index 2792d366e279501c6d64b55cc789a947df209bda..94f49ae0e78b169f168491d3fa0c8d8b0af188bb 100644

--- a/Source/modules/screen_orientation/ScreenOrientationController.cpp

+++ b/Source/modules/screen_orientation/ScreenOrientationController.cpp

@@ -56,7 +56,7 @@ WebScreenOrientationType ScreenOrientationController::computeOrientation(FrameVi

if (LayoutTestSupport::isRunningLayoutTest())

return WebScreenOrientationPortraitPrimary;

- FloatRect rect = screenRect(view);

+ IntRect rect = screenRect(view);

uint16_t rotation = screenOrientationAngle(view);

bool isTallDisplay = rotation % 180 ? rect.height() < rect.width() : rect.height() > rect.width();

switch (rotation) {

« Source/core/page/WindowFeatures.cpp ('K') | « Source/core/page/WindowFeatures.cpp ('k') | Source/platform/PlatformScreen.h » ('j') | Source/platform/PlatformScreen.cpp » ('J')