Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: Source/core/frame/Window.idl

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/Window.idl
diff --git a/Source/core/frame/Window.idl b/Source/core/frame/Window.idl
index a4120ed7aaf43a28502feb94dae265119c6044f0..5c141c9bdbd550b8e9c5609bdab3ccd3ab7106cb 100644
--- a/Source/core/frame/Window.idl
+++ b/Source/core/frame/Window.idl
@@ -101,10 +101,10 @@
[RuntimeEnabled=CSSOMSmoothScroll] void scrollTo([Default=Undefined] optional ScrollToOptions scrollToOptions);
void scroll(double x, double y);
[RuntimeEnabled=CSSOMSmoothScroll] void scroll([Default=Undefined] optional ScrollToOptions scrollOptions);
- void moveBy([Default=Undefined] optional float x, [Default=Undefined] optional float y); // FIXME: this should take longs not floats.
- void moveTo([Default=Undefined] optional float x, [Default=Undefined] optional float y); // FIXME: this should take longs not floats.
- void resizeBy([Default=Undefined] optional float x, [Default=Undefined] optional float y); // FIXME: this should take longs not floats.
- void resizeTo([Default=Undefined] optional float width, [Default=Undefined] optional float height); // FIXME: this should take longs not floats.
+ void moveBy(optional long x = 0, optional long y = 0);
Jens Widell 2015/01/28 12:29:55 All of these were previously no-ops when called wi
Mike West 2015/01/28 13:33:17 Calling these methods without arguments doesn't ma
Jens Widell 2015/01/28 14:09:23 Firefox 35: arguments are not optional. IE 11: arg
+ void moveTo(optional long x, optional long y);
+ void resizeBy(optional long x = 0, optional long y = 0);
+ void resizeTo(optional long width, optional long height);
[DoNotCheckSecurity] readonly attribute boolean closed;

Powered by Google App Engine
This is Rietveld 408576698