Use IntRect instead of FloatRect for window positions and sizes

Source/web/PopupContainer.cpp

 /*
  * Copyright (c) 2011, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 94 matching lines @@
 #endif
 }
 
 void PopupContainer::trace(Visitor* visitor)
 {
     visitor->trace(m_frameView);
     visitor->trace(m_listBox);
     Widget::trace(visitor);
 }
 
-IntRect PopupContainer::layoutAndCalculateWidgetRectInternal(IntRect widgetRectInScreen, int targetControlHeight, const FloatRect& windowRect, const FloatRect& screen, bool isRTL, const int rtlOffset, const int verticalOffset, const IntSize& transformOffset, PopupContent* listBox, bool& needToResizeView)
+IntRect PopupContainer::layoutAndCalculateWidgetRectInternal(IntRect widgetRectInScreen, int targetControlHeight, const IntRect& windowRect, const IntRect& screen, bool isRTL, const int rtlOffset, const int verticalOffset, const IntSize& transformOffset, PopupContent* listBox, bool& needToResizeView)
 {
     ASSERT(listBox);
     if (windowRect.x() >= screen.x() && windowRect.maxX() <= screen.maxX() && (widgetRectInScreen.x() < screen.x() || widgetRectInScreen.maxX() > screen.maxX())) {
         // First, inverse the popup alignment if it does not fit the screen -
         // this might fix things (or make them better).
         IntRect inverseWidgetRectInScreen = widgetRectInScreen;
         inverseWidgetRectInScreen.setX(inverseWidgetRectInScreen.x() + (isRTL ? -rtlOffset : rtlOffset));
         inverseWidgetRectInScreen.setY(inverseWidgetRectInScreen.y() + (isRTL ? -verticalOffset : verticalOffset));
-        IntRect enclosingScreen = enclosingIntRect(screen);
-        unsigned originalCutoff = std::max(enclosingScreen.x() - widgetRectInScreen.x(), 0) + std::max(widgetRectInScreen.maxX() - enclosingScreen.maxX(), 0);
-        unsigned inverseCutoff = std::max(enclosingScreen.x() - inverseWidgetRectInScreen.x(), 0) + std::max(inverseWidgetRectInScreen.maxX() - enclosingScreen.maxX(), 0);
+        unsigned originalCutoff = std::max(screen.x() - widgetRectInScreen.x(), 0) + std::max(widgetRectInScreen.maxX() - screen.maxX(), 0);
+        unsigned inverseCutoff = std::max(screen.x() - inverseWidgetRectInScreen.x(), 0) + std::max(inverseWidgetRectInScreen.maxX() - screen.maxX(), 0);
 
         // Accept the inverse popup alignment if the trimmed content gets
         // shorter than that in the original alignment case.
         if (inverseCutoff < originalCutoff)
             widgetRectInScreen = inverseWidgetRectInScreen;
 
         if (widgetRectInScreen.x() < screen.x()) {
             widgetRectInScreen.setWidth(widgetRectInScreen.maxX() - screen.x());
             widgetRectInScreen.setX(screen.x());
             listBox->setMaxWidthAndLayout(std::max(widgetRectInScreen.width() - borderSize * 2, 0));
@@ skipping 54 matching lines @@
     // points. If the <select>/<input> is transformed, they are not the same.
     int verticalOffset = - m_controlPosition.p4().y() + m_controlPosition.p3().y();
     int verticalForRTLOffset = isRTL ? verticalOffset : 0;
 
     // Assume m_listBox size is already calculated.
     IntSize targetSize(m_listBox->width() + borderSize * 2, m_listBox->height() + borderSize * 2);
 
     IntRect widgetRectInScreen;
     // If the popup would extend past the bottom of the screen, open upwards
     // instead.
-    FloatRect screen = screenAvailableRect(m_frameView.get());
+    IntRect screen = screenAvailableRect(m_frameView.get());
     // Use popupInitialCoordinate.x() + rightOffset because RTL position
     // needs to be considered.
     float pageScaleFactor = m_frameView->frame().page()->pageScaleFactor();
     int popupX = round((popupInitialCoordinate.x() + rightOffset) * pageScaleFactor);
     int popupY = round((popupInitialCoordinate.y() + verticalForRTLOffset) * pageScaleFactor);
     widgetRectInScreen = chromeClient().rootViewToScreen(IntRect(popupX, popupY, targetSize.width(), targetSize.height()));
 
     // If we have multiple screens and the browser rect is in one screen, we
     // have to clip the window width to the screen width.
     // When clipping, we also need to set a maximum width for the list box.
-    FloatRect windowRect = chromeClient().windowRect();
+    IntRect windowRect = chromeClient().windowRect();
 
     bool needToResizeView = false;
     widgetRectInScreen = layoutAndCalculateWidgetRectInternal(widgetRectInScreen, targetControlHeight, windowRect, screen, isRTL, rtlOffset, verticalOffset, transformOffset, m_listBox.get(), needToResizeView);
     if (needToResizeView)
         fitToListBox();
 
     return widgetRectInScreen;
 }
 
 void PopupContainer::showPopup(FrameView* view)
@@ skipping 335 matching lines @@
 }
 
 IntPoint PopupContainer::convertSelfToChild(const Widget* child, const IntPoint& point) const
 {
     IntPoint newPoint = point;
     newPoint.moveBy(-child->location());
     return newPoint;
 }
 
 } // namespace blink