Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: Source/core/page/Chrome.cpp

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added FIXME comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/page/Chrome.h ('k') | Source/core/page/ChromeClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * Copyright (C) 2012, Samsung Electronics. All rights reserved. 4 * Copyright (C) 2012, Samsung Electronics. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 20 matching lines...) Expand all
31 #include "core/inspector/InspectorInstrumentation.h" 31 #include "core/inspector/InspectorInstrumentation.h"
32 #include "core/page/ChromeClient.h" 32 #include "core/page/ChromeClient.h"
33 #include "core/page/FrameTree.h" 33 #include "core/page/FrameTree.h"
34 #include "core/page/Page.h" 34 #include "core/page/Page.h"
35 #include "core/page/PopupOpeningObserver.h" 35 #include "core/page/PopupOpeningObserver.h"
36 #include "core/page/ScopedPageLoadDeferrer.h" 36 #include "core/page/ScopedPageLoadDeferrer.h"
37 #include "core/page/WindowFeatures.h" 37 #include "core/page/WindowFeatures.h"
38 #include "core/rendering/HitTestResult.h" 38 #include "core/rendering/HitTestResult.h"
39 #include "platform/FileChooser.h" 39 #include "platform/FileChooser.h"
40 #include "platform/Logging.h" 40 #include "platform/Logging.h"
41 #include "platform/geometry/FloatRect.h" 41 #include "platform/geometry/IntRect.h"
42 #include "platform/network/DNS.h" 42 #include "platform/network/DNS.h"
43 #include "public/platform/WebScreenInfo.h" 43 #include "public/platform/WebScreenInfo.h"
44 #include "wtf/PassRefPtr.h" 44 #include "wtf/PassRefPtr.h"
45 #include "wtf/Vector.h" 45 #include "wtf/Vector.h"
46 46
47 namespace blink { 47 namespace blink {
48 48
49 using namespace HTMLNames; 49 using namespace HTMLNames;
50 50
51 Chrome::Chrome(Page* page, ChromeClient* client) 51 Chrome::Chrome(Page* page, ChromeClient* client)
(...skipping 25 matching lines...) Expand all
77 blink::WebScreenInfo Chrome::screenInfo() const 77 blink::WebScreenInfo Chrome::screenInfo() const
78 { 78 {
79 return m_client->screenInfo(); 79 return m_client->screenInfo();
80 } 80 }
81 81
82 void Chrome::contentsSizeChanged(LocalFrame* frame, const IntSize& size) const 82 void Chrome::contentsSizeChanged(LocalFrame* frame, const IntSize& size) const
83 { 83 {
84 m_client->contentsSizeChanged(frame, size); 84 m_client->contentsSizeChanged(frame, size);
85 } 85 }
86 86
87 void Chrome::setWindowRect(const FloatRect& rect) const 87 void Chrome::setWindowRect(const IntRect& rect) const
88 { 88 {
89 m_client->setWindowRect(rect); 89 m_client->setWindowRect(rect);
90 } 90 }
91 91
92 FloatRect Chrome::windowRect() const 92 IntRect Chrome::windowRect() const
93 { 93 {
94 return m_client->windowRect(); 94 return m_client->windowRect();
95 } 95 }
96 96
97 FloatRect Chrome::pageRect() const 97 IntRect Chrome::pageRect() const
98 { 98 {
99 return m_client->pageRect(); 99 return m_client->pageRect();
100 } 100 }
101 101
102 void Chrome::focus() const 102 void Chrome::focus() const
103 { 103 {
104 m_client->focus(); 104 m_client->focus();
105 } 105 }
106 106
107 bool Chrome::canTakeFocus(WebFocusType type) const 107 bool Chrome::canTakeFocus(WebFocusType type) const
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
408 { 408 {
409 m_client->registerViewportLayers(); 409 m_client->registerViewportLayers();
410 } 410 }
411 411
412 void Chrome::willBeDestroyed() 412 void Chrome::willBeDestroyed()
413 { 413 {
414 m_client->chromeDestroyed(); 414 m_client->chromeDestroyed();
415 } 415 }
416 416
417 } // namespace blink 417 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/page/Chrome.h ('k') | Source/core/page/ChromeClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698