Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: Source/core/loader/EmptyClients.h

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added FIXME comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/Window.idl ('k') | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Eric Seidel (eric@webkit.org) 2 * Copyright (C) 2006 Eric Seidel (eric@webkit.org)
3 * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
5 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 5 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 21 matching lines...) Expand all
32 #include "core/editing/UndoStep.h" 32 #include "core/editing/UndoStep.h"
33 #include "core/inspector/InspectorClient.h" 33 #include "core/inspector/InspectorClient.h"
34 #include "core/loader/FrameLoaderClient.h" 34 #include "core/loader/FrameLoaderClient.h"
35 #include "core/page/ChromeClient.h" 35 #include "core/page/ChromeClient.h"
36 #include "core/page/ContextMenuClient.h" 36 #include "core/page/ContextMenuClient.h"
37 #include "core/page/DragClient.h" 37 #include "core/page/DragClient.h"
38 #include "core/page/EditorClient.h" 38 #include "core/page/EditorClient.h"
39 #include "core/page/Page.h" 39 #include "core/page/Page.h"
40 #include "core/page/SpellCheckerClient.h" 40 #include "core/page/SpellCheckerClient.h"
41 #include "platform/DragImage.h" 41 #include "platform/DragImage.h"
42 #include "platform/geometry/FloatRect.h" 42 #include "platform/geometry/IntRect.h"
43 #include "platform/heap/Handle.h" 43 #include "platform/heap/Handle.h"
44 #include "platform/network/ResourceError.h" 44 #include "platform/network/ResourceError.h"
45 #include "platform/text/TextCheckerClient.h" 45 #include "platform/text/TextCheckerClient.h"
46 #include "public/platform/WebFocusType.h" 46 #include "public/platform/WebFocusType.h"
47 #include "public/platform/WebScreenInfo.h" 47 #include "public/platform/WebScreenInfo.h"
48 #include "wtf/Forward.h" 48 #include "wtf/Forward.h"
49 #include <v8.h> 49 #include <v8.h>
50 50
51 /* 51 /*
52 This file holds empty Client stubs for use by WebCore. 52 This file holds empty Client stubs for use by WebCore.
(...skipping 10 matching lines...) Expand all
63 63
64 namespace blink { 64 namespace blink {
65 65
66 class EmptyChromeClient : public ChromeClient { 66 class EmptyChromeClient : public ChromeClient {
67 WTF_MAKE_FAST_ALLOCATED; 67 WTF_MAKE_FAST_ALLOCATED;
68 public: 68 public:
69 virtual ~EmptyChromeClient() { } 69 virtual ~EmptyChromeClient() { }
70 virtual void chromeDestroyed() override { } 70 virtual void chromeDestroyed() override { }
71 71
72 virtual void* webView() const override { return 0; } 72 virtual void* webView() const override { return 0; }
73 virtual void setWindowRect(const FloatRect&) override { } 73 virtual void setWindowRect(const IntRect&) override { }
74 virtual FloatRect windowRect() override { return FloatRect(); } 74 virtual IntRect windowRect() override { return IntRect(); }
75 75
76 virtual FloatRect pageRect() override { return FloatRect(); } 76 virtual IntRect pageRect() override { return IntRect(); }
77 77
78 virtual void focus() override { } 78 virtual void focus() override { }
79 79
80 virtual bool canTakeFocus(WebFocusType) override { return false; } 80 virtual bool canTakeFocus(WebFocusType) override { return false; }
81 virtual void takeFocus(WebFocusType) override { } 81 virtual void takeFocus(WebFocusType) override { }
82 82
83 virtual void focusedNodeChanged(Node*, Node*) override { } 83 virtual void focusedNodeChanged(Node*, Node*) override { }
84 virtual void focusedFrameChanged(LocalFrame*) override { } 84 virtual void focusedFrameChanged(LocalFrame*) override { }
85 virtual Page* createWindow(LocalFrame*, const FrameLoadRequest&, const Windo wFeatures&, NavigationPolicy, ShouldSendReferrer) override { return 0; } 85 virtual Page* createWindow(LocalFrame*, const FrameLoadRequest&, const Windo wFeatures&, NavigationPolicy, ShouldSendReferrer) override { return 0; }
86 virtual void show(NavigationPolicy) override { } 86 virtual void show(NavigationPolicy) override { }
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 320
321 virtual void highlight() override { } 321 virtual void highlight() override { }
322 virtual void hideHighlight() override { } 322 virtual void hideHighlight() override { }
323 }; 323 };
324 324
325 void fillWithEmptyClients(Page::PageClients&); 325 void fillWithEmptyClients(Page::PageClients&);
326 326
327 } 327 }
328 328
329 #endif // EmptyClients_h 329 #endif // EmptyClients_h
OLDNEW
« no previous file with comments | « Source/core/frame/Window.idl ('k') | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698