Use IntRect instead of FloatRect for window positions and sizes

Source/web/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 40 matching lines @@
 #include "core/page/Page.h"
 #include "core/rendering/HitTestResult.h"
 #include "core/rendering/RenderPart.h"
 #include "core/rendering/compositing/CompositedSelectionBound.h"
 #include "modules/accessibility/AXObject.h"
 #include "platform/Cursor.h"
 #include "platform/FileChooser.h"
 #include "platform/PlatformScreen.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/exported/WrappedResourceRequest.h"
-#include "platform/geometry/FloatRect.h"
 #include "platform/geometry/IntRect.h"
 #include "platform/graphics/GraphicsLayer.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebCursorInfo.h"
 #include "public/platform/WebRect.h"
 #include "public/platform/WebSelectionBound.h"
 #include "public/platform/WebURLRequest.h"
 #include "public/web/WebAXObject.h"
 #include "public/web/WebAutofillClient.h"
@@ skipping 66 matching lines @@
 void* ChromeClientImpl::webView() const
 {
     return static_cast<void*>(m_webView);
 }
 
 void ChromeClientImpl::chromeDestroyed()
 {
     // Our lifetime is bound to the WebViewImpl.
 }
 
-void ChromeClientImpl::setWindowRect(const FloatRect& r)
+void ChromeClientImpl::setWindowRect(const IntRect& r)
 {
     if (m_webView->client())
-        m_webView->client()->setWindowRect(IntRect(r));
+        m_webView->client()->setWindowRect(r);
 }
 
-FloatRect ChromeClientImpl::windowRect()
+IntRect ChromeClientImpl::windowRect()
 {
     WebRect rect;
     if (m_webView->client())
         rect = m_webView->client()->rootWindowRect();
     else {
         // These numbers will be fairly wrong. The window's x/y coordinates will
         // be the top left corner of the screen and the size will be the content
         // size instead of the window size.
         rect.width = m_webView->size().width;
         rect.height = m_webView->size().height;
     }
-    return FloatRect(rect);
+    return IntRect(rect);
 }
 
-FloatRect ChromeClientImpl::pageRect()
+IntRect ChromeClientImpl::pageRect()
 {
     // We hide the details of the window's border thickness from the web page by
     // simple re-using the window position here.  So, from the point-of-view of
     // the web page, the window has no border.
     return windowRect();

[Jens Widell, 2015/01/28 12:29:55]

This seems to be the only implementation of pageRect() that returns a non-empty
rectangle, and it returns windowRect(), which was effectively an integer
rectangle already (from a WebRect) so pageRect() was effectively an integer
rectangle already.

 }
 
 void ChromeClientImpl::focus()
 {
     if (m_webView->client())
         m_webView->client()->didFocus();
 }
 
 bool ChromeClientImpl::canTakeFocus(WebFocusType)
 {
@@ skipping 697 matching lines @@
         webframe->autofillClient()->dataListOptionsChanged(WebInputElement(&input));
 }
 
 void ChromeClientImpl::registerViewportLayers() const
 {
     if (m_webView->rootGraphicsLayer() && m_webView->layerTreeView() && m_webView->pinchVirtualViewportEnabled())
         m_webView->page()->frameHost().pinchViewport().registerLayersWithTreeView(m_webView->layerTreeView());
 }
 
 } // namespace blink