Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: Source/platform/PlatformScreen.cpp

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2008, 2009, Google Inc. All rights reserved. 2 * Copyright (c) 2008, 2009, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 } 65 }
66 66
67 bool screenIsMonochrome(Widget* widget) 67 bool screenIsMonochrome(Widget* widget)
68 { 68 {
69 HostWindow* hostWindow = toHostWindow(widget); 69 HostWindow* hostWindow = toHostWindow(widget);
70 if (!hostWindow) 70 if (!hostWindow)
71 return false; 71 return false;
72 return hostWindow->screenInfo().isMonochrome; 72 return hostWindow->screenInfo().isMonochrome;
73 } 73 }
74 74
75 FloatRect screenRect(Widget* widget) 75 IntRect screenRect(Widget* widget)
76 { 76 {
77 HostWindow* hostWindow = toHostWindow(widget); 77 HostWindow* hostWindow = toHostWindow(widget);
78 if (!hostWindow) 78 if (!hostWindow)
79 return FloatRect(); 79 return IntRect();
80 return IntRect(hostWindow->screenInfo().rect); 80 return IntRect(hostWindow->screenInfo().rect);
Jens Widell 2015/01/28 12:29:55 WebScreenInfo::rect is WebRect, so changing the re
Mike West 2015/01/28 13:33:17 Acknowledged.
81 } 81 }
82 82
83 FloatRect screenAvailableRect(Widget* widget) 83 IntRect screenAvailableRect(Widget* widget)
84 { 84 {
85 HostWindow* hostWindow = toHostWindow(widget); 85 HostWindow* hostWindow = toHostWindow(widget);
86 if (!hostWindow) 86 if (!hostWindow)
87 return FloatRect(); 87 return IntRect();
88 return IntRect(hostWindow->screenInfo().availableRect); 88 return IntRect(hostWindow->screenInfo().availableRect);
Jens Widell 2015/01/28 12:29:55 WebScreenInfo::availableRect is WebRect too.
Mike West 2015/01/28 13:33:17 Acknowledged.
89 } 89 }
90 90
91 uint16_t screenOrientationAngle(Widget* widget) 91 uint16_t screenOrientationAngle(Widget* widget)
92 { 92 {
93 HostWindow* hostWindow = toHostWindow(widget); 93 HostWindow* hostWindow = toHostWindow(widget);
94 if (!hostWindow) 94 if (!hostWindow)
95 return 0; 95 return 0;
96 return hostWindow->screenInfo().orientationAngle; 96 return hostWindow->screenInfo().orientationAngle;
97 } 97 }
98 98
99 WebScreenOrientationType screenOrientationType(Widget* widget) 99 WebScreenOrientationType screenOrientationType(Widget* widget)
100 { 100 {
101 HostWindow* hostWindow = toHostWindow(widget); 101 HostWindow* hostWindow = toHostWindow(widget);
102 if (!hostWindow) 102 if (!hostWindow)
103 return WebScreenOrientationUndefined; 103 return WebScreenOrientationUndefined;
104 return hostWindow->screenInfo().orientationType; 104 return hostWindow->screenInfo().orientationType;
105 } 105 }
106 106
107 } // namespace blink 107 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698