Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 879913002: mechanical rename of base::debug -> base::trace_event for /cc (Closed)

Created:
5 years, 11 months ago by ssid
Modified:
5 years, 10 months ago
CC:
nduca
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_trace_part3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mechanical rename of base::debug -> base::trace_event for /cc This is the last stage of the trace_event directory restructuring. This is part of a set of 3 CLs which is moving tracing clients to use the new base::trace_debug namespace. See crrev.com/837303004 and the related bug for motivations. BUG=451032 TBR=nduca@chromium.org Committed: https://crrev.com/911e40ef1f033735fdfe95a411926a1b998ddbfc Cr-Commit-Position: refs/heads/master@{#315335}

Patch Set 1 #

Patch Set 2 : Removing forward declarations in /cc folder #

Patch Set 3 : Rebase. #

Patch Set 4 : Edited a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+365 lines, -483 lines) Patch
M cc/base/math_util.h View 1 2 2 chunks +12 lines, -18 lines 0 comments Download
M cc/base/math_util.cc View 1 12 chunks +12 lines, -12 lines 0 comments Download
M cc/base/region.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M cc/base/region.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/blink/web_layer_impl.h View 1 2 2 chunks +2 lines, -7 lines 0 comments Download
M cc/blink/web_layer_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/debug/benchmark_instrumentation.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M cc/debug/devtools_instrumentation.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M cc/debug/frame_timing_tracker_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/debug/frame_viewer_instrumentation.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/debug/rendering_stats.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M cc/debug/rendering_stats.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M cc/debug/rendering_stats_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M cc/debug/traced_picture.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M cc/debug/traced_picture.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/debug/traced_value.h View 1 1 chunk +6 lines, -11 lines 0 comments Download
M cc/debug/traced_value.cc View 1 2 chunks +9 lines, -7 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer.h View 1 2 2 chunks +2 lines, -7 lines 0 comments Download
M cc/layers/layer.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/layer_client.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M cc/layers/layer_impl.h View 1 2 4 chunks +4 lines, -11 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/surface_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/surface_layer_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/output/begin_frame_args.h View 1 2 chunks +2 lines, -9 lines 0 comments Download
M cc/output/begin_frame_args.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M cc/output/filter_operation.h View 1 2 chunks +2 lines, -8 lines 0 comments Download
M cc/output/filter_operation.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/output/filter_operations.h View 1 2 chunks +2 lines, -8 lines 0 comments Download
M cc/output/filter_operations.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/quads/checkerboard_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/checkerboard_draw_quad.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/quads/content_draw_quad_base.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/content_draw_quad_base.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/quads/debug_border_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/debug_border_draw_quad.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/quads/draw_quad.h View 1 3 chunks +3 lines, -9 lines 0 comments Download
M cc/quads/draw_quad.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/io_surface_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/io_surface_draw_quad.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/quads/list_container_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/quads/picture_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/picture_draw_quad.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/render_pass.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M cc/quads/render_pass.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/render_pass_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/render_pass_draw_quad.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/quads/shared_quad_state.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M cc/quads/shared_quad_state.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/solid_color_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/solid_color_draw_quad.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/quads/stream_video_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/stream_video_draw_quad.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/quads/surface_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/surface_draw_quad.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/texture_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/texture_draw_quad.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/tile_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/tile_draw_quad.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/yuv_video_draw_quad.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/yuv_video_draw_quad.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/bitmap_tile_task_worker_pool.h View 1 2 chunks +2 lines, -7 lines 0 comments Download
M cc/resources/bitmap_tile_task_worker_pool.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M cc/resources/clip_display_item.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/clip_display_item.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M cc/resources/clip_path_display_item.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/clip_path_display_item.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M cc/resources/display_item.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/display_item_list.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/display_item_list.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M cc/resources/display_list_raster_source.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/display_list_raster_source.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/drawing_display_item.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/drawing_display_item.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/filter_display_item.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/filter_display_item.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M cc/resources/float_clip_display_item.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/float_clip_display_item.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M cc/resources/one_copy_tile_task_worker_pool.h View 1 2 chunks +4 lines, -9 lines 0 comments Download
M cc/resources/one_copy_tile_task_worker_pool.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M cc/resources/picture.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resources/picture.cc View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/picture_layer_tiling_set.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/picture_pile_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_pile_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/pixel_buffer_tile_task_worker_pool.h View 1 2 chunks +4 lines, -9 lines 0 comments Download
M cc/resources/pixel_buffer_tile_task_worker_pool.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M cc/resources/raster_source.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/raster_tile_priority_queue_all.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/raster_tile_priority_queue_all.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/resources/tile.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_draw_info.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_draw_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_manager.h View 1 3 chunks +4 lines, -11 lines 0 comments Download
M cc/resources/tile_manager.cc View 1 2 chunks +8 lines, -7 lines 0 comments Download
M cc/resources/tile_priority.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/tile_priority.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/transform_display_item.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/transform_display_item.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M cc/resources/transparency_display_item.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/transparency_display_item.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/zero_copy_tile_task_worker_pool.h View 1 2 chunks +2 lines, -7 lines 0 comments Download
M cc/resources/zero_copy_tile_task_worker_pool.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M cc/scheduler/begin_frame_source.h View 1 2 7 chunks +7 lines, -7 lines 0 comments Download
M cc/scheduler/begin_frame_source.cc View 1 2 5 chunks +6 lines, -5 lines 0 comments Download
M cc/scheduler/begin_frame_source_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M cc/scheduler/delay_based_time_source.h View 1 2 chunks +2 lines, -8 lines 0 comments Download
M cc/scheduler/delay_based_time_source.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/scheduler/scheduler.h View 1 2 chunks +3 lines, -9 lines 0 comments Download
M cc/scheduler/scheduler.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M cc/scheduler/scheduler_settings.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M cc/scheduler/scheduler_settings.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 1 2 2 chunks +4 lines, -10 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/fake_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/ordered_simple_task_runner.h View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M cc/test/ordered_simple_task_runner.cc View 1 2 2 chunks +9 lines, -9 lines 0 comments Download
M cc/test/scheduler_test_common.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/scheduler_test_common.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/test_now_source.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/test_now_source.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 chunks +12 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/proxy.h View 1 2 chunks +2 lines, -8 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/thread_proxy.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (9 generated)
ssid
5 years, 11 months ago (2015-01-27 17:59:24 UTC) #2
ssid
PTAL.
5 years, 10 months ago (2015-02-03 11:09:51 UTC) #3
Primiano Tucci (use gerrit)
Not a cc/ OWNER but LGTM. +skyostil Please don't merge this CL even if you ...
5 years, 10 months ago (2015-02-03 11:53:12 UTC) #5
Sami
Change lgtm, but let's land this how Primiano suggested.
5 years, 10 months ago (2015-02-03 14:00:41 UTC) #6
Primiano Tucci (use gerrit)
On 2015/02/03 14:00:41, Sami wrote: > Change lgtm, but let's land this how Primiano suggested. ...
5 years, 10 months ago (2015-02-03 18:39:30 UTC) #7
ssid
On 2015/02/03 18:39:30, Primiano Tucci wrote: > On 2015/02/03 14:00:41, Sami wrote: > > Change ...
5 years, 10 months ago (2015-02-03 21:01:04 UTC) #8
Primiano Tucci (use gerrit)
Rebase (PS 3 and 4) LGTM. Ship it. Now!
5 years, 10 months ago (2015-02-09 11:05:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879913002/60001
5 years, 10 months ago (2015-02-09 11:08:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/41357)
5 years, 10 months ago (2015-02-09 11:17:14 UTC) #13
Primiano Tucci (use gerrit)
On 2015/02/09 11:17:14, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-09 11:58:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879913002/60001
5 years, 10 months ago (2015-02-09 11:59:55 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ng on ...
5 years, 10 months ago (2015-02-09 13:10:03 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879913002/60001
5 years, 10 months ago (2015-02-09 14:13:17 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879913002/60001
5 years, 10 months ago (2015-02-09 16:48:16 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-09 17:55:30 UTC) #24
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 17:56:12 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/911e40ef1f033735fdfe95a411926a1b998ddbfc
Cr-Commit-Position: refs/heads/master@{#315335}

Powered by Google App Engine
This is Rietveld 408576698