Issue 879883002: Refactoring in unit_test_launcher.cc:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 879883002: Refactoring in unit_test_launcher.cc: (Closed)

Created:
5 years, 11 months ago by Paweł Hajdan Jr.

Modified:
5 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Refactoring in unit_test_launcher.cc: - expose RunUnitTestsSerially and RunUnitTestsBatch - hide private static ProcessTestResults in anonymous namespace This will be used to implement ios-specific unit test relaunch logic. Exposing the helpers makes it possible to re-use them in ios code. BUG=426870 R=sky@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/9471d2a13c88409c7155a22dda9b84217190e889

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+255 lines, -266 lines)			Patch
	M	base/test/launcher/unit_test_launcher.h	View		3 chunks	+12 lines, -42 lines	0 comments	Download
	M	base/test/launcher/unit_test_launcher.cc	View		2 chunks	+243 lines, -224 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/9471d2a13c88409c7155a22dda9b84217190e889 Cr-Commit-Position: refs/heads/master@{#313476}

5 years, 10 months ago (2015-01-28 11:05:30 UTC) #4

Paweł Hajdan Jr.

5 years, 10 months ago (2015-01-28 11:05:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9471d2a13c88409c7155a22dda9b84217190e889 (presubmit successful).