Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 879863004: Log force-alt-protocols command line flag usage. (Closed)

Created:
5 years, 11 months ago by Bence
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Log force-alt-protocols command line flag usage. BUG=452514 Committed: https://crrev.com/493bc568527caeab93a173e4feea85c0c86c439e Cr-Commit-Position: refs/heads/master@{#313566}

Patch Set 1 #

Patch Set 2 : Log user action, not internal call. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/io_thread.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Bence
Ryan, PTAL. Thanks.
5 years, 11 months ago (2015-01-27 16:31:17 UTC) #2
Ryan Hamilton
lgtm
5 years, 10 months ago (2015-01-28 18:30:35 UTC) #3
Bence
Alexei: PTAL at tools/metrics/actions/actions.xml. Thanks.
5 years, 10 months ago (2015-01-28 19:12:32 UTC) #5
Alexei Svitkine (slow)
lgtm
5 years, 10 months ago (2015-01-28 19:14:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879863004/20001
5 years, 10 months ago (2015-01-28 19:51:15 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-28 19:56:50 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/493bc568527caeab93a173e4feea85c0c86c439e Cr-Commit-Position: refs/heads/master@{#313566}
5 years, 10 months ago (2015-01-28 19:57:57 UTC) #10
Bence
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1016163002/ by bnc@chromium.org. ...
5 years, 9 months ago (2015-03-18 20:23:36 UTC) #11
Bence
5 years, 9 months ago (2015-03-18 21:50:07 UTC) #12
Message was sent while issue was closed. 
On 2015/03/18 20:23:36, Bence wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1016163002/ by mailto:bnc@chromium.org.
> 
> The reason for reverting is: Reverting bogus CL.  base::RecordAction cannot be
> called on the IO thread.  This CL actually causes debug build Chromium to
crash
> upon startup if invoked with the --use-spdy=force-alt-protocols command line
> flag..

Reverting at https://crrev.com/1023483002 instead.

Powered by Google App Engine
This is Rietveld 408576698