Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 879833003: Revert of [MemSheriff] Exclude/suppress failing tests on DrMemory. (Closed)

Created:
5 years, 10 months ago by Justin Novosad
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang, earthdok
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [MemSheriff] Exclude/suppress failing tests on DrMemory. (patchset #1 id:1 of https://codereview.chromium.org/875923002/) Reason for revert: Memory error was resolved Original issue's description: > [MemSheriff] Exclude/suppress failing tests on DrMemory. > > BUG=446256, 451991, 451992, 451988, 293125, 451983 > TBR=thestig@chromium.org > NOTRY=true > > Committed: https://crrev.com/78924e45a48629664deeee14e3c84638ae13ff66 > Cr-Commit-Position: refs/heads/master@{#313064} TBR=thestig@chromium.org,earthdok@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=446256, 451991, 451992, 451988, 293125, 451983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M tools/valgrind/drmemory/suppressions_full.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/valgrind/gtest_exclude/cc_unittests.gtest-drmemory.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/valgrind/gtest_exclude/content_browsertests.gtest-drmemory.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Justin Novosad
Created Revert of [MemSheriff] Exclude/suppress failing tests on DrMemory.
5 years, 10 months ago (2015-02-03 16:18:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879833003/1
5 years, 10 months ago (2015-02-03 16:18:52 UTC) #2
commit-bot: I haz the power
Failed to apply patch for tools/valgrind/drmemory/suppressions_full.txt: While running git apply --index -3 -p1; error: patch ...
5 years, 10 months ago (2015-02-03 16:19:20 UTC) #5
Justin Novosad
On 2015/02/03 16:19:20, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
5 years, 10 months ago (2015-02-03 16:20:35 UTC) #7
earthdok
5 years, 10 months ago (2015-02-03 16:20:50 UTC) #8
This affects 6 issues, some of which are not fixed. Please remove only the
relevant suppression

Powered by Google App Engine
This is Rietveld 408576698