Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 879803003: Revert of Build in C++11 mode on Unix-like bots. (Closed)

Created:
5 years, 10 months ago by mtklein
Modified:
5 years, 10 months ago
Reviewers:
stephana, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Build in C++11 mode on Unix-like bots. (patchset #4 id:60001 of https://codereview.chromium.org/868233008/) Reason for revert: Perf-Ubuntu12, and Test-Ubuntu12, Build-Nacl all too old. Android and Chrome OS builders look ok. Android testers look ok. Chrome OS testers haven't run yet. Original issue's description: > Build in C++11 mode on Unix-like bots. > > Mac and Windows bots are already building in C++11 mode. > This turns on the rest, mostly to see what work remains. > > This will probably break a few bots. It'd be nice if we could let those > all come in as red before reverting this so I can see the full list to fix. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/779e49602a9c8f4d2799504822e01bcafbcaa534 TBR=stephana@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/b9d4d279cd381392e69c6638457055264696f7eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M gyp/common_conditions.gypi View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Build in C++11 mode on Unix-like bots.
5 years, 10 months ago (2015-02-04 15:05:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879803003/1
5 years, 10 months ago (2015-02-04 15:06:20 UTC) #2
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 15:06:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b9d4d279cd381392e69c6638457055264696f7eb

Powered by Google App Engine
This is Rietveld 408576698