Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 879803002: Fix pnacl_support_extension null build on linux/mac (no longer have libgcc_eh.a). (Closed)

Created:
5 years, 11 months ago by jvoung (off chromium)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix pnacl_support_extension null build on linux/mac (no longer have libgcc_eh.a). The libgcc_eh.a file is no longer in the translator tarball possibly after NaCl revision: 1fceb45: (dschuff) Wrap PNaCl sandboxed translator build in toolchain_build recipe Cr-Commit-Position: refs/heads/master@{#312891}, fixed this for windows builds, but not linux / mac. Committed: https://crrev.com/37489c3ca46109c75690825910333192b15f32e3 Cr-Commit-Position: refs/heads/master@{#313192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jvoung (off chromium)
5 years, 11 months ago (2015-01-27 00:43:01 UTC) #2
Derek Schuff
lgtm
5 years, 11 months ago (2015-01-27 01:09:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879803002/1
5 years, 11 months ago (2015-01-27 01:15:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 01:29:37 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 01:32:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37489c3ca46109c75690825910333192b15f32e3
Cr-Commit-Position: refs/heads/master@{#313192}

Powered by Google App Engine
This is Rietveld 408576698