Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 879763004: Workaround long paths on Windows by excluding the offending component. (Closed)

Created:
5 years, 11 months ago by phoglund_chromium
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Workaround long paths on Windows by excluding the offending component. Fortunately we don't need phantomjs anyway. BUG=451985 R=kjellander@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS/+/293837

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M build_apprtc_closure.py View 3 chunks +13 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
phoglund_chromium
5 years, 11 months ago (2015-01-27 17:27:05 UTC) #2
kjellander_chromium
lgtm https://codereview.chromium.org/879763004/diff/1/build_apprtc_closure.py File build_apprtc_closure.py (right): https://codereview.chromium.org/879763004/diff/1/build_apprtc_closure.py#newcode26 build_apprtc_closure.py:26: for line in fileinput.input(package_json, inplace=True): Ha, I didn't ...
5 years, 11 months ago (2015-01-27 21:00:30 UTC) #3
phoglund_chromium
https://codereview.chromium.org/879763004/diff/1/build_apprtc_closure.py File build_apprtc_closure.py (right): https://codereview.chromium.org/879763004/diff/1/build_apprtc_closure.py#newcode26 build_apprtc_closure.py:26: for line in fileinput.input(package_json, inplace=True): On 2015/01/27 21:00:30, kjellander ...
5 years, 11 months ago (2015-01-28 08:29:03 UTC) #4
phoglund_chromium
5 years, 11 months ago (2015-01-28 08:29:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r293837 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698