Remove dependencies of InMemoryURLIndex on Profile

Remove dependencies of InMemoryURLIndex on Profile

Pass to InMemoryURLIndex a pointer to the owning HistoryService and
remove the reference to Profile that is no longer necessary.

Fix the unit tests to no longer pass the Profile, and to call the
Shutdown method before destroying the object so that it properly
remove itself from the HistoryService observer list.

BUG=370850
Committed: https://crrev.com/1ec74aa117bb1abac0e1042075ca48b9b8e42cc5
Cr-Commit-Position: refs/heads/master@{#313485}

[sdefresne, 2015-01-26 23:02:22]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org

[sdefresne, 2015-01-26 23:02:23]

Please take a look.

Note that I explicitly removed the ScopedObserver<> because the code uses the
history_service_ in multiple location and it seemed pointless to use both a
ScopedObserver<> and a variable to store the same information.

[droger, 2015-01-27 09:32:32]

https://codereview.chromium.org/879763002/diff/1/chrome/browser/history/in_me...
File chrome/browser/history/in_memory_url_index.cc (right):

https://codereview.chromium.org/879763002/diff/1/chrome/browser/history/in_me...
chrome/browser/history/in_memory_url_index.cc:114:
history_service_->RemoveObserver(this);
What happens if ShutDown is never called, is the observer leaked?
Or if ShutDown must be called, can we DCHECK (shutdown_) in the destructor?

[sdefresne, 2015-01-27 10:13:57]

https://codereview.chromium.org/879763002/diff/1/chrome/browser/history/in_me...
File chrome/browser/history/in_memory_url_index.cc (right):

https://codereview.chromium.org/879763002/diff/1/chrome/browser/history/in_me...
chrome/browser/history/in_memory_url_index.cc:114:
history_service_->RemoveObserver(this);
On 2015/01/27 at 09:32:32, droger wrote:
> What happens if ShutDown is never called, is the observer leaked?
> Or if ShutDown must be called, can we DCHECK (shutdown_) in the destructor?

Yes, the observer would have been leaked. I added the DCHECK(). It is okay since
the only client code is the HistoryService itself (which does call ShutDown())
and from unit tests that I fixed.

[droger, 2015-01-27 10:15:12]

lgtm

[sdefresne, 2015-01-28 09:43:52]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2015-01-28 09:44:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/879763002/50001

[commit-bot: I haz the power, 2015-01-28 10:25:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-28 10:25:38]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[sdefresne, 2015-01-28 10:54:45]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2015-01-28 10:55:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/879763002/70001

[commit-bot: I haz the power, 2015-01-28 11:59:49]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2015-01-28 12:01:08]

Patchset 5 (id:??) landed as
https://crrev.com/1ec74aa117bb1abac0e1042075ca48b9b8e42cc5
Cr-Commit-Position: refs/heads/master@{#313485}