Issue 879743004: Remove the EventFactory machinery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 879743004: Remove the EventFactory machinery. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove the EventFactory machinery. This leaves behind some python bits with the event_factory name, but that proved difficult to remove right now. This at least simplifies the code. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/17b609a5ec3f1f4cf6c7be4cfb2b51c920023f2e

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -188 lines)			Patch
M	sky/engine/build/scripts/make_event_factory.py	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	sky/engine/build/scripts/scripts.gni	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	sky/engine/build/scripts/scripts.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	sky/engine/build/scripts/templates/EventFactory.cpp.tmpl	View	1 chunk	+0 lines, -27 lines	0 comments	Download
M	sky/engine/core/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/Init.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/Init.cpp	View	3 chunks	+0 lines, -13 lines	0 comments	Download
M	sky/engine/core/core.gni	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/Document.h	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	sky/engine/core/dom/Document.cpp	View	2 chunks	+0 lines, -25 lines	0 comments	Download
M	sky/engine/core/dom/Document.idl	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	sky/engine/core/events/EventFactory.h	View	1 chunk	+0 lines, -58 lines	0 comments	Download
M	sky/engine/core/events/EventTarget.h	View	1 chunk	+6 lines, -1 line	0 comments	Download
D	sky/engine/core/events/ThreadLocalEventNames.h	View	1 chunk	+0 lines, -32 lines	0 comments	Download

Total messages: 3 (1 generated)

esprehn

5 years, 11 months ago (2015-01-26 23:11:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
17b609a5ec3f1f4cf6c7be4cfb2b51c920023f2e (presubmit successful).