Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: LayoutTests/fast/css/touch-action-parsing.html

Issue 87973002: add pan-x and pan-y support to CSS touch-action parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: merge to trunk Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css/touch-action-parsing.html
diff --git a/LayoutTests/fast/css/touch-action-parsing.html b/LayoutTests/fast/css/touch-action-parsing.html
old mode 100644
new mode 100755
index 41037807204d837010682711a29330aafc73754b..b1b0fcedb526499184e2085c763803b3f0db0945
--- a/LayoutTests/fast/css/touch-action-parsing.html
+++ b/LayoutTests/fast/css/touch-action-parsing.html
@@ -17,8 +17,13 @@
<div class="test" id="default" expected="auto"></div>
<div class="test defnone" id="stylesheet-none" expected="none"></div>
<div class="test defnone" id="explicit-auto" style="touch-action: auto;" expected="auto"></div>
+<div class="test defnone" id="explicit-pan-x" style="touch-action: pan-x;" expected="pan-x"></div>
Rick Byers 2013/12/06 21:44:04 why use 'defnone' on these three tests? I'd just
gnana 2013/12/10 18:24:37 Done.
+<div class="test defnone" id="explicit-pan-y" style="touch-action: pan-y;" expected="pan-y"></div>
+<div class="test defnone" id="explicit-pan-x-pan-y" style="touch-action: pan-x pan-y;" expected="pan-x pan-y"></div>
Rick Byers 2013/12/06 21:44:04 it's probably worth adding 'pan-y pan-x'. I'm gue
gnana 2013/12/10 18:24:37 Done.
<div class="test" id="explicit-none" style="touch-action: none;" expected="none"></div>
<div class="test" id="explicit-invalid" style="touch-action: bogus;" expected="auto"></div>
+<div class="test" id="explicit-invalid" style="touch-action: auto pan-x;" expected="auto"></div>
Rick Byers 2013/12/06 21:44:04 it's illegal to use the same ID more than once - p
Rick Byers 2013/12/06 21:44:04 Apply the 'defnone' class here and expect it to be
gnana 2013/12/10 18:24:37 Done.
gnana 2013/12/10 18:24:37 Done.
+<div class="test" id="explicit-invalid" style="touch-action: none pan-y;" expected="auto"></div>
Rick Byers 2013/12/06 21:44:04 just for a bit more variety, I'd suggest 'pan-y no
gnana 2013/12/10 18:24:37 Done.
<div style="touch-action: none;">
<div class="test" id="not-inherited" expected="auto"></div>
<div class="test" id="inherit" style="touch-action: inherit;" expected="none"></div>
« no previous file with comments | « no previous file | LayoutTests/fast/css/touch-action-parsing-expected.txt » ('j') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698