add pan-x and pan-y support to CSS touch-action parsing.

Source/core/css/CSSParser-in.cpp

Index: Source/core/css/CSSParser-in.cpp
diff --git a/Source/core/css/CSSParser-in.cpp b/Source/core/css/CSSParser-in.cpp
old mode 100644
new mode 100755
index 42ee2d6562b093c9411593a4a0da33e90e7a4ef6..567c7ea76d7002dc69b90e807e0de743fc797304
--- a/Source/core/css/CSSParser-in.cpp
+++ b/Source/core/css/CSSParser-in.cpp
@@ -621,10 +621,6 @@ static inline bool isValidKeywordPropertyAndValue(CSSPropertyID propertyId, int
         if ((valueID >= CSSValueCapitalize && valueID <= CSSValueLowercase) || valueID == CSSValueNone)
             return true;
         break;
-    case CSSPropertyTouchAction: // auto | none
-        if (RuntimeEnabledFeatures::cssTouchActionEnabled() && (valueID == CSSValueAuto || valueID == CSSValueNone))
-            return true;
-        break;
     case CSSPropertyTouchActionDelay: // none | script
         if (RuntimeEnabledFeatures::cssTouchActionEnabled() && (valueID == CSSValueScript || valueID == CSSValueNone))
             return true;
@@ -882,7 +878,6 @@ static inline bool isKeywordPropertyID(CSSPropertyID propertyId)
     case CSSPropertyTextTransform:
     case CSSPropertyTextUnderlineMode:
     case CSSPropertyTextUnderlineStyle:
-    case CSSPropertyTouchAction:
     case CSSPropertyTouchActionDelay:
     case CSSPropertyVisibility:
     case CSSPropertyWebkitAppearance:
@@ -2706,6 +2701,11 @@ bool CSSParser::parseValue(CSSPropertyID propId, bool important)
     case CSSPropertyShapeImageThreshold:
         validPrimitive = (RuntimeEnabledFeatures::cssShapesEnabled() && !id && validUnit(value, FNumber));
         break;
+
+    case CSSPropertyTouchAction:
+        // auto | none | [pan-x || pan-y]
+        return parseTouchAction(propId, important);
+
     case CSSPropertyBorderBottomStyle:
     case CSSPropertyBorderCollapse:
     case CSSPropertyBorderLeftStyle:
@@ -2746,7 +2746,6 @@ bool CSSParser::parseValue(CSSPropertyID propId, bool important)
     case CSSPropertyTextTransform:
     case CSSPropertyTextUnderlineMode:
     case CSSPropertyTextUnderlineStyle:
-    case CSSPropertyTouchAction:
     case CSSPropertyTouchActionDelay:
     case CSSPropertyVariable:
     case CSSPropertyVisibility:
@@ -9014,6 +9013,50 @@ bool CSSParser::parsePerspectiveOrigin(CSSPropertyID propId, CSSPropertyID& prop
     return value;
 }
 
+bool CSSParser::parseTouchAction(CSSPropertyID propId, bool important)
+{
+    if (propId == CSSPropertyTouchAction
+        && !RuntimeEnabledFeatures::cssTouchActionEnabled())

[eseidel, 2013/12/13 17:19:06]

CSSRuntimeFeatures has the ability to enable properties individually if that's
what you're going for.  WE don't have support for toggling values through
CSSRuntimeFeatures yet however.

[Rick Byers, 2013/12/13 21:16:15]

Oh cool, I hadn't noticed RuntimeCSSEnabled.cpp before (perhaps it was added
after I landed my initial touch-action parsing CL ages ago).  Since Gnana is
just moving my code around here, I suggest he land it as is, and I'll move this
over to the RuntimeCSSEnabled.cpp infrastructure when I land the CL that
switches from 'test' to 'experimental' mode.

+        return false;
+
+    CSSParserValue* value = m_valueList->current();
+    RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
+    if (m_valueList->size() == 1 && value && (value->id == CSSValueAuto || value->id == CSSValueNone)) {

[eseidel, 2013/12/13 17:19:06]

I don't understand the size=1 case.  Is this an optimization?

[eseidel, 2013/12/13 17:34:36]

nevermind.  This is to distinguis touch-action: single-value from touch-action:
many values;

the former can only be auto or none, the later is x/y pan.

+        list->append(cssValuePool().createIdentifierValue(value->id));
+        addProperty(propId, list.release(), important);
+        m_valueList->next();
+        return true;
+    }
+
+    bool isValid = true;
+    while (isValid && value) {
+        switch (value->id) {
+        case CSSValuePanX:
+        case CSSValuePanY: {
+            RefPtr<CSSValue> panValue = cssValuePool().createIdentifierValue(value->id);
+            if (list->hasValue(panValue.get())) {
+                isValid = false;
+                break;
+            }
+            list->append(panValue.release());
+            break;
+        }
+        default:
+            isValid = false;
+            break;
+        }
+        if (isValid)
+            value = m_valueList->next();
+    }
+
+    if (list->length() && isValid) {
+        addProperty(propId, list.release(), important);
+        return true;
+    }
+
+    return false;
+}
+
 void CSSParser::addTextDecorationProperty(CSSPropertyID propId, PassRefPtr<CSSValue> value, bool important)
 {
     // The text-decoration-line property takes priority over text-decoration, unless the latter has important priority set.