Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 879693006: X87: Double field values need sNaN -> qNaN canonicalization. (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Double field values need sNaN -> qNaN canonicalization. Fix the failure introduced by 0381acf7b32893f3ec8b097ec269d6743682905a (r26213). When storing Double field to external double array, we need to do special qNaN --> sNan recovery on X87 port. BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/a3ac322a2ae0351bfad02fd188d3fe3cc0805b4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M src/x87/lithium-codegen-x87.cc View 1 chunk +26 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
chunyang.dai
PTAL. thanks.
5 years, 10 months ago (2015-02-06 07:57:14 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-06 07:59:09 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a3ac322a2ae0351bfad02fd188d3fe3cc0805b4d Cr-Commit-Position: refs/heads/master@{#26477}
5 years, 10 months ago (2015-02-06 08:07:08 UTC) #4
chunyang.dai
5 years, 10 months ago (2015-02-06 08:07:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a3ac322a2ae0351bfad02fd188d3fe3cc0805b4d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698