Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 879693004: Remove IC age from Code. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove IC age from Code. BUG= Committed: https://crrev.com/3cd88975a14edab4d0a7eb34e600d3d31bfdc36d Cr-Commit-Position: refs/heads/master@{#26468}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Address comment #

Patch Set 4 : Remove tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -124 lines) Patch
M src/factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.h View 1 2 3 2 chunks +4 lines, -11 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 3 chunks +0 lines, -104 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ulan
PTAL. Since v8:3629 is fixed, ICs and handlers do not retain objects.
5 years, 10 months ago (2015-02-05 15:05:32 UTC) #2
mvstanton
Modulo one comment, it LGTM. thanks! https://codereview.chromium.org/879693004/diff/20001/src/objects.cc File src/objects.cc (left): https://codereview.chromium.org/879693004/diff/20001/src/objects.cc#oldcode10345 src/objects.cc:10345: code()->ClearInlineCaches(); Also remove ...
5 years, 10 months ago (2015-02-05 15:16:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879693004/60001
5 years, 10 months ago (2015-02-05 15:33:13 UTC) #8
ulan
Thanks! I uploaded new patch set. Landing. https://codereview.chromium.org/879693004/diff/20001/src/objects.cc File src/objects.cc (left): https://codereview.chromium.org/879693004/diff/20001/src/objects.cc#oldcode10345 src/objects.cc:10345: code()->ClearInlineCaches(); On ...
5 years, 10 months ago (2015-02-05 15:33:18 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-05 16:40:34 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 16:40:55 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/3cd88975a14edab4d0a7eb34e600d3d31bfdc36d
Cr-Commit-Position: refs/heads/master@{#26468}

Powered by Google App Engine
This is Rietveld 408576698