Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 879653002: Remove --ash-enable-tray-dragging flag (Closed)

Created:
5 years, 11 months ago by pkotwicz
Modified:
5 years, 11 months ago
Reviewers:
sadrul, oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove --ash-enable-tray-dragging flag BUG=449849 TEST=Peter is happy Committed: https://crrev.com/3b8c3d2c4048171e15d9ad09ca290623b7b8ccdb Cr-Commit-Position: refs/heads/master@{#313119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -263 lines) Patch
M ash/ash.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/ash_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 chunk +1 line, -8 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 2 chunks +1 line, -24 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 2 chunks +0 lines, -55 lines 0 comments Download
M ash/wm/gestures/shelf_gesture_handler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/wm/gestures/shelf_gesture_handler.cc View 3 chunks +1 line, -14 lines 0 comments Download
D ash/wm/gestures/tray_gesture_handler.h View 1 chunk +0 lines, -46 lines 0 comments Download
D ash/wm/gestures/tray_gesture_handler.cc View 1 chunk +0 lines, -107 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pkotwicz
Sadrul, PTAL
5 years, 11 months ago (2015-01-26 18:38:05 UTC) #2
sadrul
LGTM! > TEST=Peter is happy I hope that doesn't mean no more code-cleanups! ;)
5 years, 11 months ago (2015-01-26 18:54:14 UTC) #3
pkotwicz
oshima@ for ash/ OWNERS
5 years, 11 months ago (2015-01-26 19:01:49 UTC) #5
oshima
lgtm
5 years, 11 months ago (2015-01-26 19:07:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879653002/1
5 years, 11 months ago (2015-01-26 19:10:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 20:31:49 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 20:33:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b8c3d2c4048171e15d9ad09ca290623b7b8ccdb
Cr-Commit-Position: refs/heads/master@{#313119}

Powered by Google App Engine
This is Rietveld 408576698