Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 879603002: Replace marquee in test to make it deterministic. (Closed)

Created:
5 years, 11 months ago by Daniel Bratell
Modified:
5 years, 11 months ago
Reviewers:
Mike West
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace marquee in test to make it deterministic. Marquees cause visible state changes in the layout tree both because they trigger extra layers and because the scroll offset is not well known. Most often the LayoutTest framework captures marquees after the shadow <div> has been created but before the layout engine has reacted to the transformation commands and animation. But not always. This groups the marquee tests in TestExpectations (they should be treated as the same problem) and replaces one marquee with an equally good generic element. BUG=439478 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189015

Patch Set 1 #

Patch Set 2 : And slimming paint. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -42 lines) Patch
M LayoutTests/TestExpectations View 1 5 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/inline-block/003.html View 2 chunks +5 lines, -11 lines 0 comments Download
M LayoutTests/platform/win/fast/inline-block/003-expected.txt View 1 chunk +12 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Daniel Bratell
mkwst, could you please take a look?
5 years, 11 months ago (2015-01-26 17:31:33 UTC) #2
Mike West
lgtm Nice! LGTM.
5 years, 11 months ago (2015-01-26 18:09:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879603002/20001
5 years, 11 months ago (2015-01-27 09:03:39 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 09:50:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189015

Powered by Google App Engine
This is Rietveld 408576698