Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 879583002: [turbofan] Remove GenericAlgorithm from verifier and graph replay. (Closed)

Created:
5 years, 11 months ago by titzer
Modified:
5 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove GenericAlgorithm from verifier and graph replay. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/3937dd679bba168499d87b4b412429bad083d628 Cr-Commit-Position: refs/heads/master@{#26280}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -88 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A src/compiler/all-nodes.h View 1 chunk +42 lines, -0 lines 1 comment Download
A src/compiler/all-nodes.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M src/compiler/diamond.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-reducer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/graph-replay.h View 3 chunks +1 line, -5 lines 0 comments Download
M src/compiler/graph-replay.cc View 2 chunks +18 lines, -14 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 2 chunks +1 line, -52 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-context-specialization.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
titzer
5 years, 11 months ago (2015-01-26 16:34:57 UTC) #1
Michael Starzinger
LGTM, just one comment. https://codereview.chromium.org/879583002/diff/1/src/compiler/all-nodes.h File src/compiler/all-nodes.h (right): https://codereview.chromium.org/879583002/diff/1/src/compiler/all-nodes.h#newcode19 src/compiler/all-nodes.h:19: class AllNodes { I think ...
5 years, 11 months ago (2015-01-26 17:16:56 UTC) #2
titzer
On 2015/01/26 17:16:56, Michael Starzinger wrote: > LGTM, just one comment. > > https://codereview.chromium.org/879583002/diff/1/src/compiler/all-nodes.h > ...
5 years, 11 months ago (2015-01-26 17:23:58 UTC) #3
titzer
On 2015/01/26 17:16:56, Michael Starzinger wrote: > LGTM, just one comment. > > https://codereview.chromium.org/879583002/diff/1/src/compiler/all-nodes.h > ...
5 years, 11 months ago (2015-01-26 17:24:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879583002/1
5 years, 11 months ago (2015-01-26 18:05:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 18:35:13 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 18:35:19 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3937dd679bba168499d87b4b412429bad083d628
Cr-Commit-Position: refs/heads/master@{#26280}

Powered by Google App Engine
This is Rietveld 408576698