[V8] Added Script::is_debugger_script flag for embedders

include/v8.h

Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 1df17bbaf5107619ca6245610c32a8e9cda9322e..0eee66de8622b47c5d1a71a0f89a92d6a6431fbc 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -976,21 +976,29 @@ class ScriptOrigin {
       Handle<Integer> resource_line_offset = Handle<Integer>(),
       Handle<Integer> resource_column_offset = Handle<Integer>(),
       Handle<Boolean> resource_is_shared_cross_origin = Handle<Boolean>(),
-      Handle<Integer> script_id = Handle<Integer>())
+      Handle<Integer> script_id = Handle<Integer>(),
+      Handle<Boolean> resource_is_debugger_script = Handle<Boolean>())
       : resource_name_(resource_name),
         resource_line_offset_(resource_line_offset),
         resource_column_offset_(resource_column_offset),
+        resource_is_debugger_script_(resource_is_debugger_script),
         resource_is_shared_cross_origin_(resource_is_shared_cross_origin),
-        script_id_(script_id) { }
+        script_id_(script_id) {}
   V8_INLINE Handle<Value> ResourceName() const;
   V8_INLINE Handle<Integer> ResourceLineOffset() const;
   V8_INLINE Handle<Integer> ResourceColumnOffset() const;
+  /**
+    * Returns true for embdedder's debugger scripts

[noordhuis, 2015/01/26 23:51:17]

Typo: s/embdedder/embedder/

From the diff, it's not clear to me why it's called something something
debugger, it doesn't seem debug related at all.  Maybe 'builtin' or 'native' is
a better name?

[kozy, 2015/01/27 10:02:14]

Done.

I suppose that bultin and native is not better name. This flag added for
DevTools, we need to mark some scripts as internal. From DevTools side this flag
can be called as isDebuggerScript. I understood that from V8 side this name is
not correct. Maybe add embedder to name: isEmbedderInternalScript is better.

+    */
+  V8_INLINE Handle<Boolean> ResourceIsDebuggerScript() const;
   V8_INLINE Handle<Boolean> ResourceIsSharedCrossOrigin() const;
   V8_INLINE Handle<Integer> ScriptID() const;
+
  private:
   Handle<Value> resource_name_;
   Handle<Integer> resource_line_offset_;
   Handle<Integer> resource_column_offset_;
+  Handle<Boolean> resource_is_debugger_script_;
   Handle<Boolean> resource_is_shared_cross_origin_;
   Handle<Integer> script_id_;
 };
@@ -1136,6 +1144,7 @@ class V8_EXPORT ScriptCompiler {
     Handle<Value> resource_name;
     Handle<Integer> resource_line_offset;
     Handle<Integer> resource_column_offset;
+    Handle<Boolean> resource_is_debugger_script;
     Handle<Boolean> resource_is_shared_cross_origin;
 
     // Cached data from previous compilation (if a kConsume*Cache flag is
@@ -6726,6 +6735,11 @@ Handle<Integer> ScriptOrigin::ResourceColumnOffset() const {
 }
 
 
+Handle<Boolean> ScriptOrigin::ResourceIsDebuggerScript() const {
+  return resource_is_debugger_script_;
+}
+
+
 Handle<Boolean> ScriptOrigin::ResourceIsSharedCrossOrigin() const {
   return resource_is_shared_cross_origin_;
 }
@@ -6742,6 +6756,7 @@ ScriptCompiler::Source::Source(Local<String> string, const ScriptOrigin& origin,
       resource_name(origin.ResourceName()),
       resource_line_offset(origin.ResourceLineOffset()),
       resource_column_offset(origin.ResourceColumnOffset()),
+      resource_is_debugger_script(origin.ResourceIsDebuggerScript()),
       resource_is_shared_cross_origin(origin.ResourceIsSharedCrossOrigin()),
       cached_data(data) {}