[V8] Added Script::is_debugger_script flag for embedders

include/v8.h

Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 1df17bbaf5107619ca6245610c32a8e9cda9322e..ca1c23dbddf9b61ea45be6ee74a056fb54cd8cf8 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -976,21 +976,25 @@ class ScriptOrigin {
       Handle<Integer> resource_line_offset = Handle<Integer>(),
       Handle<Integer> resource_column_offset = Handle<Integer>(),
       Handle<Boolean> resource_is_shared_cross_origin = Handle<Boolean>(),
-      Handle<Integer> script_id = Handle<Integer>())
+      Handle<Integer> script_id = Handle<Integer>(),
+      Handle<Boolean> resource_is_internal_script = Handle<Boolean>())

[yurys, 2015/01/26 15:41:06]

The "internal" term is somewhat confusing. Can we rename to something like
is_debugger_script?

[kozy, 2015/01/26 16:42:13]

Done.

       : resource_name_(resource_name),
         resource_line_offset_(resource_line_offset),
         resource_column_offset_(resource_column_offset),
+        resource_is_internal_script_(resource_is_internal_script),

[yurys, 2015/01/26 15:46:43]

Would it make sense to have something like Script::SetDebugData(Handle<Value>)
and keep flags like that in such  object?

[kozy, 2015/01/26 16:42:13]

Acknowledged.

         resource_is_shared_cross_origin_(resource_is_shared_cross_origin),
-        script_id_(script_id) { }
+        script_id_(script_id) {}
   V8_INLINE Handle<Value> ResourceName() const;
   V8_INLINE Handle<Integer> ResourceLineOffset() const;
   V8_INLINE Handle<Integer> ResourceColumnOffset() const;
+  V8_INLINE Handle<Boolean> ResourceIsInternalScript() const;

[yurys, 2015/01/26 15:41:05]

Can you add a comment to the method describing meaning of the flag?

[kozy, 2015/01/26 16:42:13]

Done.

   V8_INLINE Handle<Boolean> ResourceIsSharedCrossOrigin() const;
   V8_INLINE Handle<Integer> ScriptID() const;
  private:
   Handle<Value> resource_name_;
   Handle<Integer> resource_line_offset_;
   Handle<Integer> resource_column_offset_;
+  Handle<Boolean> resource_is_internal_script_;
   Handle<Boolean> resource_is_shared_cross_origin_;
   Handle<Integer> script_id_;
 };
@@ -1136,6 +1140,7 @@ class V8_EXPORT ScriptCompiler {
     Handle<Value> resource_name;
     Handle<Integer> resource_line_offset;
     Handle<Integer> resource_column_offset;
+    Handle<Boolean> resource_is_internal_script;
     Handle<Boolean> resource_is_shared_cross_origin;
 
     // Cached data from previous compilation (if a kConsume*Cache flag is
@@ -6726,6 +6731,11 @@ Handle<Integer> ScriptOrigin::ResourceColumnOffset() const {
 }
 
 
+Handle<Boolean> ScriptOrigin::ResourceIsInternalScript() const {
+  return resource_is_internal_script_;
+}
+
+
 Handle<Boolean> ScriptOrigin::ResourceIsSharedCrossOrigin() const {
   return resource_is_shared_cross_origin_;
 }
@@ -6742,6 +6752,7 @@ ScriptCompiler::Source::Source(Local<String> string, const ScriptOrigin& origin,
       resource_name(origin.ResourceName()),
       resource_line_offset(origin.ResourceLineOffset()),
       resource_column_offset(origin.ResourceColumnOffset()),
+      resource_is_internal_script(origin.ResourceIsInternalScript()),
       resource_is_shared_cross_origin(origin.ResourceIsSharedCrossOrigin()),
       cached_data(data) {}