Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Issue 879533006: Send notification when render process has failed to launch. (Closed)

Created:
5 years, 11 months ago by Krzysztof Olczyk
Modified:
5 years, 11 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send notification when render process has failed to launch. Before this patch, information about renderer that crashed at startup (i.e. failed to start) was not forwarded to WebContents, etc... BUG=452812 Committed: https://crrev.com/d0f1f7659d4aee2aba2123d2c9a3db66cf8023ff Cr-Commit-Position: refs/heads/master@{#313461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M content/browser/renderer_host/render_process_host_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 5 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Krzysztof Olczyk
Hi avi, ccameron, jam, could you please take a look at this review?
5 years, 11 months ago (2015-01-27 14:21:18 UTC) #2
jam
lgtm please don't add 3 reviewers in the future, just pick one. also do you ...
5 years, 11 months ago (2015-01-27 16:22:30 UTC) #3
Krzysztof Olczyk
On 2015/01/27 at 16:22:30, jam wrote: > lgtm > > please don't add 3 reviewers ...
5 years, 11 months ago (2015-01-28 08:09:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879533006/1
5 years, 11 months ago (2015-01-28 08:11:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-28 08:23:18 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-28 08:24:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0f1f7659d4aee2aba2123d2c9a3db66cf8023ff
Cr-Commit-Position: refs/heads/master@{#313461}

Powered by Google App Engine
This is Rietveld 408576698