Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: sync/android/java/src/org/chromium/sync/signin/ChromeSigninController.java

Issue 879533004: Rewrite AndroidSyncSettings to be significantly simpler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@android-sync
Patch Set: Add another deprecated method for transitioning. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/android/java/src/org/chromium/sync/signin/ChromeSigninController.java
diff --git a/sync/android/java/src/org/chromium/sync/signin/ChromeSigninController.java b/sync/android/java/src/org/chromium/sync/signin/ChromeSigninController.java
index 3e0b8ca7ae5eca47c177588e86632deefa21daac..fde40a5d9e1b90c2d936a48d6320e88d05b5a86e 100644
--- a/sync/android/java/src/org/chromium/sync/signin/ChromeSigninController.java
+++ b/sync/android/java/src/org/chromium/sync/signin/ChromeSigninController.java
@@ -14,8 +14,16 @@ import com.google.ipc.invalidation.external.client.contrib.MultiplexingGcmListen
import org.chromium.base.ObserverList;
import org.chromium.base.VisibleForTesting;
+import org.chromium.sync.AndroidSyncSettings;
+/**
+ * Caches the signed-in username in the app prefs.
+ */
public class ChromeSigninController {
+
+ /**
+ * Interface for listening to signin events from ChromeSigninController.
+ */
public interface Listener {
/**
* Called when the user signs out of Chrome.
@@ -36,10 +44,13 @@ public class ChromeSigninController {
private final ObserverList<Listener> mListeners = new ObserverList<Listener>();
+ private final AndroidSyncSettings mAndroidSyncSettings;
+
private boolean mGcmInitialized;
private ChromeSigninController(Context context) {
mApplicationContext = context.getApplicationContext();
+ mAndroidSyncSettings = AndroidSyncSettings.get(context);
}
/**
@@ -73,6 +84,7 @@ public class ChromeSigninController {
PreferenceManager.getDefaultSharedPreferences(mApplicationContext).edit()
.putString(SIGNED_IN_ACCOUNT_KEY, accountName)
.apply();
+ mAndroidSyncSettings.updateAccount(getSignedInUser());
nyquist 2015/02/06 03:03:57 Could this be done by SigninManager instead? I thi
maxbogue 2015/02/10 09:20:00 Added a TODO for this line. I can file a bug for m
}
public void clearSignedInUser() {

Powered by Google App Engine
This is Rietveld 408576698