Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1930)

Unified Diff: Source/web/mac/WebSubstringUtil.mm

Issue 879533003: Remove Mac native font type members from FontPlatformData (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removing MemoryActivatedFont Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/fonts/skia/FontCustomPlatformDataSkia.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/mac/WebSubstringUtil.mm
diff --git a/Source/web/mac/WebSubstringUtil.mm b/Source/web/mac/WebSubstringUtil.mm
index 2b726f046891d9de12ac8b6d5764bd658f30f3c1..36c33da37c048e7b5567a1c46698da9a883594d3 100644
--- a/Source/web/mac/WebSubstringUtil.mm
+++ b/Source/web/mac/WebSubstringUtil.mm
@@ -78,7 +78,8 @@ static NSAttributedString* attributedSubstringFromRange(const Range* range)
continue;
RenderStyle* style = renderer->style();
- NSFont* font = style->font().primaryFont()->getNSFont();
+ // TODO(dro): Check whether we can really use the CTFont here.
+ const NSFont* font = style->font().primaryFont()->getNSFont();
// If the platform font can't be loaded, it's likely that the site is
// using a web font. For now, just use the default font instead.
// TODO(rsesek): Change the font activation flags to allow other processes
« no previous file with comments | « Source/platform/fonts/skia/FontCustomPlatformDataSkia.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698