Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: Source/platform/fonts/FontCustomPlatformData.h

Issue 879533003: Remove Mac native font type members from FontPlatformData (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removing MemoryActivatedFont Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/blink_platform.gypi ('k') | Source/platform/fonts/FontCustomPlatformData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/FontCustomPlatformData.h
diff --git a/Source/platform/fonts/FontCustomPlatformData.h b/Source/platform/fonts/FontCustomPlatformData.h
index c2f7824767e492e52caa4ca54e74e8b394c3c77b..2144628f34f87c0d5f0ab2af3ca751c825f1387a 100644
--- a/Source/platform/fonts/FontCustomPlatformData.h
+++ b/Source/platform/fonts/FontCustomPlatformData.h
@@ -32,6 +32,7 @@
#ifndef FontCustomPlatformData_h
#define FontCustomPlatformData_h
+#include "SkTypeface.h"
#include "platform/PlatformExport.h"
#include "platform/fonts/FontOrientation.h"
#include "wtf/Forward.h"
@@ -39,12 +40,6 @@
#include "wtf/RefPtr.h"
#include "wtf/text/WTFString.h"
-#if OS(MACOSX)
-#include "wtf/RetainPtr.h"
-#include <CoreFoundation/CFBase.h>
-typedef struct CGFont* CGFontRef;
-#endif
-
class SkTypeface;
namespace blink {
@@ -63,12 +58,10 @@ public:
static bool supportsFormat(const String&);
private:
-#if OS(MACOSX)
- explicit FontCustomPlatformData(CGFontRef, PassRefPtr<SkTypeface>);
- RetainPtr<CGFontRef> m_cgFont;
-#else
- explicit FontCustomPlatformData(PassRefPtr<SkTypeface>);
-#endif
+ // TODO(dro): Move this back to the implementation file.
+ explicit FontCustomPlatformData(PassRefPtr<SkTypeface> typeface)
+ : m_typeface(typeface) { };
+
RefPtr<SkTypeface> m_typeface;
};
« no previous file with comments | « Source/platform/blink_platform.gypi ('k') | Source/platform/fonts/FontCustomPlatformData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698