Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 879523003: media_stream_audio_processor: Default enabled Finch experiments now also applies (Closed)

Created:
5 years, 11 months ago by bjornv
Modified:
5 years, 11 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media_stream_audio_processor: Default enabled Finch experiments now also applies The Finch experiments ReplaceAECMWithAEC and UseDelayAgnosticAEC make appropriate changes to webrtc::AudioProcessing at create time. If any of these experiments are enabled by default using a different experiment name (which it should have) the desired config change is not made. BUG=368175, 450193 Committed: https://crrev.com/391ccbb5399b7bb7b8c82deb689085d87697d8ab Cr-Commit-Position: refs/heads/master@{#313079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/renderer/media/media_stream_audio_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
bjornv
Per, can you PTAL at this small change.
5 years, 11 months ago (2015-01-26 15:07:23 UTC) #2
perkj_chrome
lgtm
5 years, 11 months ago (2015-01-26 15:16:19 UTC) #3
perkj_chrome
lgtm
5 years, 11 months ago (2015-01-26 15:16:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879523003/1
5 years, 11 months ago (2015-01-26 15:59:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 16:44:34 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 16:45:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/391ccbb5399b7bb7b8c82deb689085d87697d8ab
Cr-Commit-Position: refs/heads/master@{#313079}

Powered by Google App Engine
This is Rietveld 408576698