Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 879503002: Add resources for the new <select> Popup Menu (Closed)

Created:
5 years, 11 months ago by keishi
Modified:
5 years, 11 months ago
Reviewers:
haraken, dstockwell
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add resources for the new <select> Popup Menu Adding js/css resources for the new <select> Popup Menu. BUG=346582 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189086

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -0 lines) Patch
A Source/web/resources/listPicker.css View 1 chunk +10 lines, -0 lines 0 comments Download
A Source/web/resources/listPicker.js View 1 chunk +234 lines, -0 lines 0 comments Download
M public/blink_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
keishi
These files have already been reviewed by tkent in https://codereview.chromium.org/736883002/. I am splitting that CL ...
5 years, 11 months ago (2015-01-26 17:44:24 UTC) #2
haraken
rubberstamp LGTM based on tkent-san's LG in https://codereview.chromium.org/736883002/
5 years, 11 months ago (2015-01-26 23:25:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879503002/1
5 years, 11 months ago (2015-01-28 04:00:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/25141)
5 years, 11 months ago (2015-01-28 04:05:53 UTC) #7
keishi
I need a public/ reviewer. dstockwell@ could you take a look? Thanks.
5 years, 11 months ago (2015-01-28 04:07:58 UTC) #9
dstockwell
lgtm
5 years, 11 months ago (2015-01-28 04:12:55 UTC) #10
keishi
Thanks.
5 years, 11 months ago (2015-01-28 04:13:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879503002/1
5 years, 11 months ago (2015-01-28 04:14:13 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-28 05:13:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189086

Powered by Google App Engine
This is Rietveld 408576698