Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 879483004: Don't touch the renderer without the lock! (Closed)

Created:
5 years, 11 months ago by DaleCurtis
Modified:
5 years, 11 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't touch the renderer without the lock! It's accessed concurrently on the render thread and the media thread internally and externally. BUG=452093 TEST=none Committed: https://crrev.com/3a9f3a8b726c46f9907a9b1d1658f3e0c6169377 Cr-Commit-Position: refs/heads/master@{#313158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/base/pipeline.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
DaleCurtis
5 years, 11 months ago (2015-01-26 19:28:47 UTC) #2
xhwang
lgtm
5 years, 11 months ago (2015-01-26 20:57:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879483004/1
5 years, 11 months ago (2015-01-26 21:01:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 22:44:47 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 22:45:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a9f3a8b726c46f9907a9b1d1658f3e0c6169377
Cr-Commit-Position: refs/heads/master@{#313158}

Powered by Google App Engine
This is Rietveld 408576698