Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 879473002: MIPS: Fixed Hydrogen environment handling for mul-i ARM and ARM64. (Closed)

Created:
5 years, 11 months ago by balazs.kilvady
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fixed Hydrogen environment handling for mul-i ARM and ARM64. Port a7d67a64f11100434b196143e2ba516f8c13697a Original commit message: The whole logic in DoMul makes me cry, so I made only the minimal change to fix the issue... BUG=v8:451322 LOG=y Committed: https://crrev.com/0ae9eb038fd47f94493141ebf6144363363fac6b Cr-Commit-Position: refs/heads/master@{#26277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/mips/lithium-mips.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 11 months ago (2015-01-26 12:28:18 UTC) #2
paul.l...
LGTM.
5 years, 11 months ago (2015-01-26 15:15:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879473002/1
5 years, 11 months ago (2015-01-26 15:46:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 16:16:00 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 16:16:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ae9eb038fd47f94493141ebf6144363363fac6b
Cr-Commit-Position: refs/heads/master@{#26277}

Powered by Google App Engine
This is Rietveld 408576698